LayoutTests/svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-setOrientToAngle-call.js - Issue 36843003: Improve remaining TypeErrors in bindings code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-setOrientToAngle-call.js

Issue 36843003: Improve remaining TypeErrors in bindings code. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: vibration. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.txt ('k') | LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-setOrientToAngle-call.js

diff --git a/LayoutTests/svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-setOrientToAngle-call.js b/LayoutTests/svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-setOrientToAngle-call.js

index 92262d257bedb12f1a44ec3e2d51eca71d307b2f..e4b140ccff1e3ccfa3f4ce8049f000ddd8326287 100644

--- a/LayoutTests/svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-setOrientToAngle-call.js

+++ b/LayoutTests/svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-setOrientToAngle-call.js

@@ -35,11 +35,12 @@ rootSVGElement.appendChild(pathElement);

shouldBe("markerElement.orientType.baseVal", "SVGMarkerElement.SVG_MARKER_ORIENT_AUTO");

shouldBe("markerElement.orientAngle.baseVal.value", "0");

-shouldThrow("markerElement.setOrientToAngle()", "'TypeError: Type error'");

-shouldThrow("markerElement.setOrientToAngle(true)", "'TypeError: Type error'");

-shouldThrow("markerElement.setOrientToAngle(2)", "'TypeError: Type error'");

-shouldThrow("markerElement.setOrientToAngle('aString')", "'TypeError: Type error'");

-shouldThrow("markerElement.setOrientToAngle(markerElement)", "'TypeError: Type error'");

+var typeError = '"TypeError: Failed to execute \'setOrientToAngle\' on \'SVGMarkerElement\': parameter 1 is not of type \'SVGAngle\'."';

+shouldThrow("markerElement.setOrientToAngle()", typeError);

+shouldThrow("markerElement.setOrientToAngle(true)", typeError);

+shouldThrow("markerElement.setOrientToAngle(2)", typeError);

+shouldThrow("markerElement.setOrientToAngle('aString')", typeError);

+shouldThrow("markerElement.setOrientToAngle(markerElement)", typeError);

function repaintTest() {

markerElement.setOrientToAngle(rootSVGElement.createSVGAngle());