Issue 368053002: Stack overflow checkers are now compatible with ASAN's detect_stack_use_after_return mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 368053002: Stack overflow checkers are now compatible with ASAN's detect_stack_use_after_return mode. (Closed)

Created:
6 years, 5 months ago by Igor Sheludko

Modified:
6 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Stack overflow checkers are now compatible with ASAN's detect_stack_use_after_return mode. BUG=chromium:376287 BUG=chromium:376262 BUG=chromium:369962 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22183

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -64 lines)			Patch
M	src/api.cc	View	1 chunk	+3 lines, -12 lines	0 comments	Download
M	src/base/macros.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/execution.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/execution.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/preparser.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	13 chunks	+23 lines, -39 lines	0 comments	Download

Total messages: 3 (0 generated)

Igor Sheludko

PTAL. I think we can now run ASAN'ified V8 with enabled detect_stack_use_after_return mode.

6 years, 5 months ago (2014-07-02 20:21:54 UTC) #1

Igor Sheludko

6 years, 5 months ago (2014-07-03 08:52:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22183 (presubmit successful).