Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: src/api.cc

Issue 368053002: Stack overflow checkers are now compatible with ASAN's detect_stack_use_after_return mode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/base/macros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 7c484de53ee1e537a8abeefdce1e0cab69e4952e..9e6e7921220735cb5d9f42bd43c87bd52a0bba71 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -1848,19 +1848,10 @@ v8::TryCatch::TryCatch()
rethrow_(false),
has_terminated_(false) {
Reset();
- js_stack_comparable_address_ = this;
-#ifdef V8_USE_ADDRESS_SANITIZER
- void* asan_fake_stack_handle = __asan_get_current_fake_stack();
- if (asan_fake_stack_handle != NULL) {
- js_stack_comparable_address_ = __asan_addr_is_in_fake_stack(
- asan_fake_stack_handle, js_stack_comparable_address_, NULL, NULL);
- CHECK(js_stack_comparable_address_ != NULL);
- }
-#endif
// Special handling for simulators which have a separate JS stack.
- js_stack_comparable_address_ = reinterpret_cast<void*>(
- v8::internal::SimulatorStack::RegisterCTryCatch(
- reinterpret_cast<uintptr_t>(js_stack_comparable_address_)));
+ js_stack_comparable_address_ =
+ reinterpret_cast<void*>(v8::internal::SimulatorStack::RegisterCTryCatch(
+ GetCurrentStackPosition()));
isolate_->RegisterTryCatchHandler(this);
}
« no previous file with comments | « no previous file | src/base/macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698