src/isolate.cc - Issue 368053002: Stack overflow checkers are now compatible with ASAN's detect_stack_use_after_return mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 368053002: Stack overflow checkers are now compatible with ASAN's detect_stack_use_after_return mode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 8f2fa4aa098ff373b19e013d29c8c9147d98afb9..5eb1021e7f98af3e9d76c6698819f43bcbfd1e7e 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -2354,7 +2354,7 @@ bool StackLimitCheck::JsHasOverflowed() const {

uintptr_t jssp = reinterpret_cast<uintptr_t>(jssp_address);

if (jssp < stack_guard->real_jslimit()) return true;

#endif // USE_SIMULATOR

- return reinterpret_cast<uintptr_t>(this) < stack_guard->real_climit();

+ return GetCurrentStackPosition() < stack_guard->real_climit();

}

« no previous file with comments | « src/isolate.h ('k') | src/preparser.h » ('j') | no next file with comments »