Refactoring activity logger

Enable logging of page redirections.

BUG=388287
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177320

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177531

[pmarch, 2014-07-01 12:16:31]

Haraken, Pavel

CL for review, please.

Petr

[haraken, 2014-07-01 12:36:54]

LGTM

[pfeldman, 2014-07-01 15:37:50]

rslgtm

[pmarch, 2014-07-01 15:38:43]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-07-01 15:39:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/367483005/1

[commit-bot: I haz the power, 2014-07-01 16:48:41]

Change committed as 177320

[eseidel, 2014-07-01 23:58:43]

Somehow this appears to have broken a bunch of animation tests on mac??

animations/play-state-initially-paused.html
animations/change-keyframes.html
transitions/interrupt-zero-duration.html
transitions/change-duration-during-transition.html
virtual/threaded/animations/change-keyframes.html
virtual/threaded/animations/play-state-initially-paused.html
virtual/threaded/transitions/change-duration-during-transition.html
virtual/threaded/transitions/interrupt-zero-duration.html

---
/mnt/data/b/build/slave/WebKit_Linux__dbg_/build/layout-test-results/animations/change-keyframes-expected.txt
+++
/mnt/data/b/build/slave/WebKit_Linux__dbg_/build/layout-test-results/animations/change-keyframes-actual.txt
@@ -1,4 +1,13 @@
-Warning this test is running in real-time and may be flaky.
-PASS - "left" property for "box" element at 0.5s saw something close to: 200
-PASS - "top" property for "box" element at 1s saw something close to: 100
-
+CONSOLE ERROR: line 49: Uncaught illegal access
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x156
+  RenderBlock {HTML} at (0,0) size 800x156
+    RenderBody {BODY} at (8,8) size 784x140
+      RenderBlock (anonymous) at (0,0) size 784x40
+        RenderText {#text} at (0,0) size 731x39
+          text run at (0,0) width 731: "This test performs an animation of the
left property and makes sure it is animating. Then it stops the animation,
changes the"
+          text run at (0,20) width 609: "keyframes to an animation of the top
property, restarts the animation and makes sure top is animating."
+      RenderBlock {DIV} at (0,140) size 784x0
+layer at (108,48) size 100x100
+  RenderBlock (relative positioned) {DIV} at (0,40) size 100x100
[bgcolor=#0000FF]

[eseidel, 2014-07-02 00:05:17]

Appears to have broken animation tests with "Uncaught illegal access" console
logs.

That appears to be a v8 exception.  Not sure how this could cause that.

[eseidel, 2014-07-02 00:07:48]

This is the first failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/...

[eseidel, 2014-07-02 00:13:47]

I've filed bug 390732 about this issue and will start by trying to revert this
patch.

[eseidel, 2014-07-02 00:14:53]

A revert of this CL has been created in
https://codereview.chromium.org/362133003/ by eseidel@chromium.org.

The reason for reverting is: This is the leading candidate for the "uncaught
illegal access" console log failures in animation tests which started around the
time of this commit.

BUG=390732.

[lushnikov, 2014-07-02 12:12:09]

On 2014/07/02 00:14:53, eseidel wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/362133003/ by mailto:eseidel@chromium.org.
> 
> The reason for reverting is: This is the leading candidate for the "uncaught
> illegal access" console log failures in animation tests which started around
the
> time of this commit.
> 
> BUG=390732.

eseidel's revert didn't apply.
Here's a revert of the patch that got landed:
https://codereview.chromium.org/363913002

[pmarch, 2014-07-04 09:09:32]

On 2014/07/02 12:12:09, lushnikov wrote:
> On 2014/07/02 00:14:53, eseidel wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/362133003/ by mailto:eseidel@chromium.org.
> > 
> > The reason for reverting is: This is the leading candidate for the "uncaught
> > illegal access" console log failures in animation tests which started around
> the
> > time of this commit.
> > 
> > BUG=390732.
> 
> eseidel's revert didn't apply.
> Here's a revert of the patch that got landed:
> https://codereview.chromium.org/363913002

resubmitting this CL as
https://code.google.com/p/chromium/issues/detail?id=390701 is fixed.

[pmarch, 2014-07-04 09:09:36]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-07-04 09:10:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/367483005/40001

[commit-bot: I haz the power, 2014-07-04 10:15:47]

Change committed as 177531