Issue 363913002: Revert "Enable logging of page redirections."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 363913002: Revert "Enable logging of page redirections." (Closed)

Created:
6 years, 5 months ago by lushnikov

Modified:
6 years, 5 months ago

Reviewers:
haraken, pmarch, pfeldman, eseidel

CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, watchdog-blink-watchlist_google.com, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert "Enable logging of page redirections." Revert of Refactoring activity logger (https://codereview.chromium.org/367483005/) Reason for revert: This is the leading candidate for the "uncaught illegal access" console log failures in animation tests which started around the time of this commit. TBR=haraken@chromium.org,pfeldman@chromium.org,pmarch@chromium.org,eseidel@chromium.org NOTREECHECKS=true NOTRY=true BUG=388287, 390732 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177365

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -42 lines)			Patch
M	Source/core/dom/Document.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/LocalDOMWindow.cpp	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	Source/core/frame/Location.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/frame/Window.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLFormElement.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/tests/ActivityLoggerTest.cpp	View	1 chunk	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/363913002/1

6 years, 5 months ago (2014-07-02 12:04:40 UTC) #3

Message was sent while issue was closed.

Change committed as 177365

Expand Messages | Collapse Messages