Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 366813007: Removed InProcessBrowserTest::CleanUpOnMainThread() (Closed)

Created:
6 years, 5 months ago by Andrew T Wilson (Slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, asanka, skanuj+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, zea+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, dmazzoni+watch_chromium.org, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, mkwst+watchlist_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, melevin+watch_chromium.org, benquan, Ilya Sherman, dominich, Jered, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, dyu1, derat+watch_chromium.org, benjhayden+dwatch_chromium.org, haitaol+watch_chromium.org, yuzo+watch_chromium.org, samarth+watch_chromium.org, paulirish+reviews_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, kmadhusu+watch_chromium.org, gcasto+watchlist_chromium.org, pfeldman, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, kalyank, plundblad+watch_chromium.org, tfarina, ben+ash_chromium.org, donnd+watch_chromium.org, yurys, aboxhall+watch_chromium.org, jfweitz+watch_chromium.org, David Black, Dane Wallinga, dtseng+watch_chromium.org, estade+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Removed InProcessBrowserTest::CleanUpOnMainThread() Changed all instances of superfluous InProcessBrowserTest::CleanUpOnMainThread() API to use BrowserTestBase::TearDownOnMainThread() instead. BUG=381181 TBR=rockot@chromium.org,sky@chromium.org,nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285173

Patch Set 1 #

Patch Set 2 : Merge to ToT, fix error with UsbApiTest #

Patch Set 3 : More merge to ToT. #

Total comments: 8

Patch Set 4 : Merge ToT #

Patch Set 5 : Trying upload again. #

Patch Set 6 : Review feedback #

Patch Set 7 : More merge error fixups. #

Patch Set 8 : Removed superfluous override. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -137 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_provider_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_interactive_uitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/customization_wallpaper_downloader_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/oobe_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_test_base.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/test/wizard_in_process_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/test/wizard_in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/power_policy_browsertest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/active_script_controller_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_apitest.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/dns/dns_apitest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_apitest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_tcp/sockets_tcp_apitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_udp/sockets_udp_apitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_display/system_display_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_test_message_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/dns_probe_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_generation_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/device_management_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_extension_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/suggestions/thumbnail_manager_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.h View 1 2 3 2 chunks +1 line, -5 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_chrome_web_ui_controller_factory_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/web_ui_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/web_ui_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Andrew T Wilson (Slow)
John, PTAL. Just wanted someone to buy-off on the general fact that I'm doing this ...
6 years, 5 months ago (2014-07-09 13:26:14 UTC) #1
jam
lgtm with nits, thanks for the cleanup https://codereview.chromium.org/366813007/diff/30001/chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc File chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc (right): https://codereview.chromium.org/366813007/diff/30001/chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc#newcode106 chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc:106: InProcessBrowserTest::TearDownOnMainThread(); nit: ...
6 years, 5 months ago (2014-07-14 17:10:05 UTC) #2
Andrew T Wilson (Slow)
https://codereview.chromium.org/366813007/diff/30001/chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc File chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc (right): https://codereview.chromium.org/366813007/diff/30001/chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc#newcode106 chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc:106: InProcessBrowserTest::TearDownOnMainThread(); On 2014/07/14 17:10:05, jam wrote: > nit: remove ...
6 years, 5 months ago (2014-07-23 12:48:42 UTC) #3
Andrew T Wilson (Slow)
The CQ bit was checked by atwilson@chromium.org
6 years, 5 months ago (2014-07-23 13:51:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/366813007/120001
6 years, 5 months ago (2014-07-23 13:52:16 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 17:32:55 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 17:53:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173864)
6 years, 5 months ago (2014-07-23 17:53:48 UTC) #8
Andrew T Wilson (Slow)
The CQ bit was checked by atwilson@chromium.org
6 years, 5 months ago (2014-07-24 08:36:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/366813007/120001
6 years, 5 months ago (2014-07-24 08:38:00 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 10:39:50 UTC) #11
Message was sent while issue was closed. 
Change committed as 285173

Powered by Google App Engine
This is Rietveld 408576698