Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Side by Side Diff: chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc

Issue 366813007: Removed InProcessBrowserTest::CleanUpOnMainThread() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed superfluous override. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/files/file_path.h" 6 #include "base/files/file_path.h"
7 #include "base/synchronization/waitable_event.h" 7 #include "base/synchronization/waitable_event.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/ssl/ssl_client_auth_requestor_mock.h" 9 #include "chrome/browser/ssl/ssl_client_auth_requestor_mock.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 86
87 auth_requestor_ = new StrictMock<SSLClientAuthRequestorMock>( 87 auth_requestor_ = new StrictMock<SSLClientAuthRequestorMock>(
88 url_request_, 88 url_request_,
89 cert_request_info_); 89 cert_request_info_);
90 90
91 io_loop_finished_event_.Signal(); 91 io_loop_finished_event_.Signal();
92 } 92 }
93 93
94 // Have to release our reference to the auth handler during the test to allow 94 // Have to release our reference to the auth handler during the test to allow
95 // it to be destroyed while the Browser and its IO thread still exist. 95 // it to be destroyed while the Browser and its IO thread still exist.
96 virtual void CleanUpOnMainThread() OVERRIDE { 96 virtual void TearDownOnMainThread() OVERRIDE {
97 BrowserThread::PostTask( 97 BrowserThread::PostTask(
98 BrowserThread::IO, FROM_HERE, 98 BrowserThread::IO, FROM_HERE,
99 base::Bind(&SSLClientCertificateSelectorTest::CleanUpOnIOThread, this)); 99 base::Bind(&SSLClientCertificateSelectorTest::CleanUpOnIOThread, this));
100 100
101 io_loop_finished_event_.Wait(); 101 io_loop_finished_event_.Wait();
102 102
103 auth_requestor_ = NULL; 103 auth_requestor_ = NULL;
104 } 104 }
105 105
106 virtual void CleanUpOnIOThread() { 106 virtual void CleanUpOnIOThread() {
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 auth_requestor_1_ = new StrictMock<SSLClientAuthRequestorMock>( 185 auth_requestor_1_ = new StrictMock<SSLClientAuthRequestorMock>(
186 url_request_1_, 186 url_request_1_,
187 cert_request_info_1_); 187 cert_request_info_1_);
188 auth_requestor_2_ = new StrictMock<SSLClientAuthRequestorMock>( 188 auth_requestor_2_ = new StrictMock<SSLClientAuthRequestorMock>(
189 url_request_2_, 189 url_request_2_,
190 cert_request_info_2_); 190 cert_request_info_2_);
191 191
192 SSLClientCertificateSelectorTest::SetUpOnIOThread(); 192 SSLClientCertificateSelectorTest::SetUpOnIOThread();
193 } 193 }
194 194
195 virtual void CleanUpOnMainThread() OVERRIDE { 195 virtual void TearDownOnMainThread() OVERRIDE {
196 auth_requestor_2_ = NULL; 196 auth_requestor_2_ = NULL;
197 auth_requestor_1_ = NULL; 197 auth_requestor_1_ = NULL;
198 SSLClientCertificateSelectorTest::CleanUpOnMainThread(); 198 SSLClientCertificateSelectorTest::TearDownOnMainThread();
199 } 199 }
200 200
201 virtual void CleanUpOnIOThread() OVERRIDE { 201 virtual void CleanUpOnIOThread() OVERRIDE {
202 delete url_request_1_; 202 delete url_request_1_;
203 delete url_request_2_; 203 delete url_request_2_;
204 SSLClientCertificateSelectorTest::CleanUpOnIOThread(); 204 SSLClientCertificateSelectorTest::CleanUpOnIOThread();
205 } 205 }
206 206
207 protected: 207 protected:
208 net::URLRequest* url_request_1_; 208 net::URLRequest* url_request_1_;
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 virtual void SetUpOnIOThread() OVERRIDE { 248 virtual void SetUpOnIOThread() OVERRIDE {
249 url_request_1_ = MakeURLRequest(url_request_context_getter_1_).release(); 249 url_request_1_ = MakeURLRequest(url_request_context_getter_1_).release();
250 250
251 auth_requestor_1_ = new StrictMock<SSLClientAuthRequestorMock>( 251 auth_requestor_1_ = new StrictMock<SSLClientAuthRequestorMock>(
252 url_request_1_, 252 url_request_1_,
253 cert_request_info_1_); 253 cert_request_info_1_);
254 254
255 SSLClientCertificateSelectorTest::SetUpOnIOThread(); 255 SSLClientCertificateSelectorTest::SetUpOnIOThread();
256 } 256 }
257 257
258 virtual void CleanUpOnMainThread() OVERRIDE { 258 virtual void TearDownOnMainThread() OVERRIDE {
259 auth_requestor_1_ = NULL; 259 auth_requestor_1_ = NULL;
260 SSLClientCertificateSelectorTest::CleanUpOnMainThread(); 260 SSLClientCertificateSelectorTest::TearDownOnMainThread();
261 } 261 }
262 262
263 virtual void CleanUpOnIOThread() OVERRIDE { 263 virtual void CleanUpOnIOThread() OVERRIDE {
264 delete url_request_1_; 264 delete url_request_1_;
265 SSLClientCertificateSelectorTest::CleanUpOnIOThread(); 265 SSLClientCertificateSelectorTest::CleanUpOnIOThread();
266 } 266 }
267 267
268 protected: 268 protected:
269 Browser* browser_1_; 269 Browser* browser_1_;
270 scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_1_; 270 scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_1_;
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 EXPECT_TRUE(ui_test_utils::SendKeyPressSync( 385 EXPECT_TRUE(ui_test_utils::SendKeyPressSync(
386 browser_1_, ui::VKEY_RETURN, false, false, false, false)); 386 browser_1_, ui::VKEY_RETURN, false, false, false, false));
387 387
388 Mock::VerifyAndClear(auth_requestor_.get()); 388 Mock::VerifyAndClear(auth_requestor_.get());
389 Mock::VerifyAndClear(auth_requestor_1_.get()); 389 Mock::VerifyAndClear(auth_requestor_1_.get());
390 390
391 // Now let the default selection for auth_requestor_ mock get checked on 391 // Now let the default selection for auth_requestor_ mock get checked on
392 // destruction. 392 // destruction.
393 EXPECT_CALL(*auth_requestor_, CertificateSelected(NULL)); 393 EXPECT_CALL(*auth_requestor_, CertificateSelected(NULL));
394 } 394 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698