Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Side by Side Diff: chrome/browser/extensions/api/socket/socket_apitest.cc

Issue 366813007: Removed InProcessBrowserTest::CleanUpOnMainThread() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed superfluous override. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ref_counted.h" 5 #include "base/memory/ref_counted.h"
6 #include "base/strings/stringprintf.h" 6 #include "base/strings/stringprintf.h"
7 #include "chrome/browser/extensions/extension_apitest.h" 7 #include "chrome/browser/extensions/extension_apitest.h"
8 #include "chrome/browser/extensions/extension_function_test_utils.h" 8 #include "chrome/browser/extensions/extension_function_test_utils.h"
9 #include "chrome/browser/extensions/extension_service.h" 9 #include "chrome/browser/extensions/extension_service.h"
10 #include "chrome/browser/extensions/extension_test_message_listener.h" 10 #include "chrome/browser/extensions/extension_test_message_listener.h"
(...skipping 21 matching lines...) Expand all
32 SocketApiTest() : resolver_event_(true, false), 32 SocketApiTest() : resolver_event_(true, false),
33 resolver_creator_( 33 resolver_creator_(
34 new extensions::MockHostResolverCreator()) { 34 new extensions::MockHostResolverCreator()) {
35 } 35 }
36 36
37 virtual void SetUpOnMainThread() OVERRIDE { 37 virtual void SetUpOnMainThread() OVERRIDE {
38 extensions::HostResolverWrapper::GetInstance()->SetHostResolverForTesting( 38 extensions::HostResolverWrapper::GetInstance()->SetHostResolverForTesting(
39 resolver_creator_->CreateMockHostResolver()); 39 resolver_creator_->CreateMockHostResolver());
40 } 40 }
41 41
42 virtual void CleanUpOnMainThread() OVERRIDE { 42 virtual void TearDownOnMainThread() OVERRIDE {
43 extensions::HostResolverWrapper::GetInstance()-> 43 extensions::HostResolverWrapper::GetInstance()->
44 SetHostResolverForTesting(NULL); 44 SetHostResolverForTesting(NULL);
45 resolver_creator_->DeleteMockHostResolver(); 45 resolver_creator_->DeleteMockHostResolver();
46 } 46 }
47 47
48 private: 48 private:
49 base::WaitableEvent resolver_event_; 49 base::WaitableEvent resolver_event_;
50 50
51 // The MockHostResolver asserts that it's used on the same thread on which 51 // The MockHostResolver asserts that it's used on the same thread on which
52 // it's created, which is actually a stronger rule than its real counterpart. 52 // it's created, which is actually a stronger rule than its real counterpart.
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 ResultCatcher catcher; 196 ResultCatcher catcher;
197 catcher.RestrictToProfile(browser()->profile()); 197 catcher.RestrictToProfile(browser()->profile());
198 ExtensionTestMessageListener listener("info_please", true); 198 ExtensionTestMessageListener listener("info_please", true);
199 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/api"))); 199 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/api")));
200 EXPECT_TRUE(listener.WaitUntilSatisfied()); 200 EXPECT_TRUE(listener.WaitUntilSatisfied());
201 listener.Reply( 201 listener.Reply(
202 base::StringPrintf("multicast:%s:%d", kHostname.c_str(), kPort)); 202 base::StringPrintf("multicast:%s:%d", kHostname.c_str(), kPort));
203 203
204 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 204 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
205 } 205 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698