[Variations] Bring variations_http_header_provider to variations component

[Variations] Bring variations_http_header_provider to variations component

Without this, the class can hardly be used within a component (unless we work around it).

Adds a workaround for link failure of components_tests due to infobar component bug (crbug.com/386171).

BUG=387751, 382865, 386171
TBR=jam
TEST=Variations*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282072

[Mathieu, 2014-07-05 13:59:40]

Hello, 

Ilya: Alexei being away, can you look at this?
Colin: components/ OWNERS

Thanks

[Mathieu, 2014-07-05 14:09:02]

On 2014/07/05 13:59:40, Mathieu Perreault wrote:
> Hello, 
> 
> Ilya: Alexei being away, can you look at this?
> Colin: components/ OWNERS
> 
> Thanks

Actually realized Ilya is not an owner, adding jwd@.

[blundell, 2014-07-07 14:08:26]

//components/components_tests.gyp LGTM

[Mathieu, 2014-07-07 18:24:54]

Latest patchset moves everything over to "variations" namespace per Alexei's
prior comment on another change:

"Nit: This component will be moving to "variations" namespace. Can you make the
new files you're adding to be in that namespace"

[jwd, 2014-07-07 19:00:42]

lgtm

[Mathieu, 2014-07-07 19:05:37]

Adding jam@ as TBR to cover gyp changes, and header changes across chrome/ due
to the rename.

Thanks, submitting.

[Mathieu, 2014-07-07 19:05:41]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-07 19:06:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/366373002/40001

[commit-bot: I haz the power, 2014-07-07 20:01:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[Mathieu, 2014-07-07 20:02:28]

The CQ bit was unchecked by mathp@chromium.org

[Mathieu, 2014-07-07 20:07:03]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-07 20:08:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/366373002/60001

[commit-bot: I haz the power, 2014-07-07 23:30:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)

[commit-bot: I haz the power, 2014-07-07 23:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-07 23:46:42]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[Mathieu, 2014-07-07 23:54:44]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-07 23:55:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/366373002/60001

[commit-bot: I haz the power, 2014-07-08 00:28:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)

[commit-bot: I haz the power, 2014-07-08 00:35:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 00:35:28]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[Mathieu, 2014-07-08 00:51:01]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-08 00:52:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/366373002/60001

[commit-bot: I haz the power, 2014-07-08 01:18:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)

[commit-bot: I haz the power, 2014-07-08 01:27:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 01:27:46]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[Mathieu, 2014-07-08 13:12:53]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-08 13:13:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/366373002/60001

[commit-bot: I haz the power, 2014-07-08 13:16:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)

[commit-bot: I haz the power, 2014-07-08 13:19:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 13:19:36]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)

[Mathieu, 2014-07-08 13:33:08]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-08 13:34:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/366373002/80001

[Mathieu, 2014-07-08 14:05:27]

The CQ bit was unchecked by mathp@chromium.org

[Mathieu, 2014-07-08 14:09:10]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-08 14:09:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/366373002/80001

[Mathieu, 2014-07-08 15:53:18]

+pkasting

Hi Peter, see what was added in the last 2 patchsets. blundell@ found this
workaround that effectively unblocks this CL (this CL is needed for me to create
another component later), and we'd like your approval. This is related to
crbug.com/386171

[Peter Kasting, 2014-07-08 18:54:40]

LGTM

https://codereview.chromium.org/366373002/diff/120001/components/infobars/tes...
File components/infobars/test/infobar_test.cc (right):

https://codereview.chromium.org/366373002/diff/120001/components/infobars/tes...
components/infobars/test/infobar_test.cc:22: kDefaultArrowTargetHeight;
Does this need to be nonzero?  If not, make it zero.  If so, consider setting
all these values to the values they have in the embedder.

[Mathieu, 2014-07-08 19:00:50]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2014-07-08 19:01:12]

Thanks, submitting!

https://codereview.chromium.org/366373002/diff/120001/components/infobars/tes...
File components/infobars/test/infobar_test.cc (right):

https://codereview.chromium.org/366373002/diff/120001/components/infobars/tes...
components/infobars/test/infobar_test.cc:22: kDefaultArrowTargetHeight;
On 2014/07/08 18:54:40, Peter Kasting wrote:
> Does this need to be nonzero?  If not, make it zero.  If so, consider setting
> all these values to the values they have in the embedder.

I've set the to the values in infobar_view.cc

[commit-bot: I haz the power, 2014-07-08 19:02:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/366373002/140001

[Mathieu, 2014-07-08 19:04:10]

The CQ bit was unchecked by mathp@chromium.org

[Mathieu, 2014-07-09 14:11:22]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-09 14:12:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/366373002/140001

[commit-bot: I haz the power, 2014-07-09 14:17:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-09 14:24:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-09 14:24:33]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Mathieu, 2014-07-09 14:32:17]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-09 14:33:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/366373002/160001

[Mathieu, 2014-07-09 14:48:28]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-09 14:48:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/366373002/180001

[commit-bot: I haz the power, 2014-07-09 17:19:30]

Change committed as 282072

[Alexei Svitkine (slow), 2014-07-14 14:13:07]

https://codereview.chromium.org/366373002/diff/180001/components/variations.gypi
File components/variations.gypi (right):

https://codereview.chromium.org/366373002/diff/180001/components/variations.g...
components/variations.gypi:17: 'components.gyp:google_core_browser',
Sigh, the original intention of this component was to be a very minimal that
depends only on base and the mt19937ar. Now this is pulling in net/ and a lot of
other dependencies. :(

https://codereview.chromium.org/366373002/diff/180001/components/variations/p...
File components/variations/proto/BUILD.gn (right):

https://codereview.chromium.org/366373002/diff/180001/components/variations/p...
components/variations/proto/BUILD.gn:9: "chrome_experiments.proto",
Hmm, it seems weird to have something that says "Chrome Experiments" in a
component, which is not supposed to be tied to Chrome (i.e. usable from other
products).

Given that this proto is sent as X-Client-Data, we should probably just rename
the proto.

[Mathieu, 2014-07-14 15:25:14]

See comments, thanks!

https://codereview.chromium.org/366373002/diff/180001/components/variations.gypi
File components/variations.gypi (right):

https://codereview.chromium.org/366373002/diff/180001/components/variations.g...
components/variations.gypi:17: 'components.gyp:google_core_browser',
On 2014/07/14 14:13:07, Alexei Svitkine wrote:
> Sigh, the original intention of this component was to be a very minimal that
> depends only on base and the mt19937ar. Now this is pulling in net/ and a lot
of
> other dependencies. :( 

Sorry, didn't know this was objectionable :\

https://codereview.chromium.org/366373002/diff/180001/components/variations/p...
File components/variations/proto/BUILD.gn (right):

https://codereview.chromium.org/366373002/diff/180001/components/variations/p...
components/variations/proto/BUILD.gn:9: "chrome_experiments.proto",
On 2014/07/14 14:13:07, Alexei Svitkine wrote:
> Hmm, it seems weird to have something that says "Chrome Experiments" in a
> component, which is not supposed to be tied to Chrome (i.e. usable from other
> products).
> 
> Given that this proto is sent as X-Client-Data, we should probably just rename
> the proto.

I'll send a follow-up change.

[blundell, 2014-07-15 06:44:20]

https://codereview.chromium.org/366373002/diff/180001/components/variations.gypi
File components/variations.gypi (right):

https://codereview.chromium.org/366373002/diff/180001/components/variations.g...
components/variations.gypi:17: 'components.gyp:google_core_browser',
On 2014/07/14 15:25:13, Mathieu Perreault wrote:
> On 2014/07/14 14:13:07, Alexei Svitkine wrote:
> > Sigh, the original intention of this component was to be a very minimal that
> > depends only on base and the mt19937ar. Now this is pulling in net/ and a
lot
> of
> > other dependencies. :( 
> 
> Sorry, didn't know this was objectionable :\

Alexei, do we want to indirect the call to google_util to go through the client
instead? That way we could avoid pulling in the dependency on the google
component.

[Alexei Svitkine (slow), 2014-07-15 13:56:09]

https://codereview.chromium.org/366373002/diff/180001/components/variations.gypi
File components/variations.gypi (right):

https://codereview.chromium.org/366373002/diff/180001/components/variations.g...
components/variations.gypi:17: 'components.gyp:google_core_browser',
On 2014/07/15 06:44:20, blundell wrote:
> On 2014/07/14 15:25:13, Mathieu Perreault wrote:
> > On 2014/07/14 14:13:07, Alexei Svitkine wrote:
> > > Sigh, the original intention of this component was to be a very minimal
that
> > > depends only on base and the mt19937ar. Now this is pulling in net/ and a
> lot
> > of
> > > other dependencies. :( 
> > 
> > Sorry, didn't know this was objectionable :\
> 
> Alexei, do we want to indirect the call to google_util to go through the
client
> instead? That way we could avoid pulling in the dependency on the google
> component.

Possibly. I'm OK living with this for now until the dependency becomes a
problem. (Originally, this component was created so for ChromeOS system
experiments, but that effort hadn't happened. We've also discussed using this
from chrome_elf which also would like minimal dependencies - but again that
didn't materialize.) Let's leave it as-is for now and re-visit if the dependency
becomes a problem.