components/variations/proto/BUILD.gn - Issue 366373002: [Variations] Bring variations_http_header_provider to variations component

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/variations/proto/BUILD.gn

Issue 366373002: [Variations] Bring variations_http_header_provider to variations component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix BUILD.gn Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//third_party/protobuf/proto_library.gni")	5 import("//third_party/protobuf/proto_library.gni")

6	6

7 proto_library("proto") {	7 proto_library("proto") {

8 sources = [	8 sources = [

	9 "chrome_experiments.proto",
	Alexei Svitkine (slow) 2014/07/14 14:13:07 Hmm, it seems weird to have something that says "C Hmm, it seems weird to have something that says "Chrome Experiments" in a component, which is not supposed to be tied to Chrome (i.e. usable from other products). Given that this proto is sent as X-Client-Data, we should probably just rename the proto. Mathieu 2014/07/14 15:25:14 I'll send a follow-up change. Show quoted text On 2014/07/14 14:13:07, Alexei Svitkine wrote: > Hmm, it seems weird to have something that says "Chrome Experiments" in a > component, which is not supposed to be tied to Chrome (i.e. usable from other > products). > > Given that this proto is sent as X-Client-Data, we should probably just rename > the proto. I'll send a follow-up change.
9 "permuted_entropy_cache.proto",	10 "permuted_entropy_cache.proto",

10 "study.proto",	11 "study.proto",

11 "variations_seed.proto",	12 "variations_seed.proto",

12 ]	13 ]

13 }	14 }

OLD	NEW

« components/variations.gypi ('K') | « components/variations/DEPS ('k') | components/variations/proto/chrome_experiments.proto » ('j') | no next file with comments »