Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 365673002: Pass a struct to ContainerNode::childrenChanged() instead of separate arguments (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, fs, blink-reviews-dom_chromium.org, dglazkov+blink, krit, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis, tkent
Project:
blink
Visibility:
Public.

Description

Pass a struct to ContainerNode::childrenChanged() instead of separate arguments Pass a struct to ContainerNode::childrenChanged() instead of separate arguments. This is more extensible this way as this virtual function has a lot of overrides. The new struct differs from the previous arguments in that: - childCountDelta integer is replaced by a ChildrenChangeType enumeration as it as always (-1: ChildRemoved, +1: ChildInserted, 0: TextChanged, -numberOfChildren: AllChildrenRemoved) - changedByParser boolean is replaced by an enumeration for better readability. This CL does not contain any functional changes to keep it small. However, this enables us to pass more information about the node being added/removed (e.g. was it an Element?) so that we can do less recalculations is some cases. This is based on WebKit r154957 by antti@apple.com: http://trac.webkit.org/changeset/154957 R=esprehn@chromium.org, eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177347

Patch Set 1 #

Patch Set 2 : Remove dead code #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -148 lines) Patch
M Source/core/dom/Attr.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Attr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CharacterData.cpp View 3 chunks +9 lines, -5 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 2 chunks +13 lines, -3 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 11 chunks +19 lines, -13 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/shadow/InsertionPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDataListElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDataListElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 3 chunks +6 lines, -16 lines 1 comment Download
M Source/core/html/HTMLFieldSetElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFieldSetElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLOptGroupElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLOptionElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLOutputElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOutputElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLScriptElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLStyleElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLStyleElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTitleElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTitleElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGClipPathElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFELightElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFELightElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFilterElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFontFaceElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFontFaceFormatElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceFormatElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFontFaceSrcElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceSrcElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGradientElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGMaskElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPatternElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGScriptElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStyleElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStyleElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTitleElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTitleElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
The CL touches a lot of files because this virtual function has a lot of ...
6 years, 5 months ago (2014-07-01 14:53:01 UTC) #1
eseidel
lgtm Much nicer.
6 years, 5 months ago (2014-07-01 23:47:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/365673002/20001
6 years, 5 months ago (2014-07-01 23:48:57 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 00:10:23 UTC) #4
Message was sent while issue was closed.
Change committed as 177347

Powered by Google App Engine
This is Rietveld 408576698