Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: Source/core/dom/Attr.h

Issue 365673002: Pass a struct to ContainerNode::childrenChanged() instead of separate arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove dead code Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/Attr.cpp » ('j') | Source/core/html/HTMLElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 virtual String nodeName() const OVERRIDE { return name(); } 74 virtual String nodeName() const OVERRIDE { return name(); }
75 virtual NodeType nodeType() const OVERRIDE { return ATTRIBUTE_NODE; } 75 virtual NodeType nodeType() const OVERRIDE { return ATTRIBUTE_NODE; }
76 76
77 virtual String nodeValue() const OVERRIDE { return value(); } 77 virtual String nodeValue() const OVERRIDE { return value(); }
78 virtual void setNodeValue(const String&) OVERRIDE; 78 virtual void setNodeValue(const String&) OVERRIDE;
79 virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) OVERRIDE; 79 virtual PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) OVERRIDE;
80 80
81 virtual bool isAttributeNode() const OVERRIDE { return true; } 81 virtual bool isAttributeNode() const OVERRIDE { return true; }
82 virtual bool childTypeAllowed(NodeType) const OVERRIDE; 82 virtual bool childTypeAllowed(NodeType) const OVERRIDE;
83 83
84 virtual void childrenChanged(bool changedByParser = false, Node* beforeChang e = 0, Node* afterChange = 0, int childCountDelta = 0) OVERRIDE; 84 virtual void childrenChanged(const ChildrenChange&) OVERRIDE;
85 85
86 Attribute& elementAttribute(); 86 Attribute& elementAttribute();
87 87
88 // Attr wraps either an element/name, or a name/value pair (when it's a stan dalone Node.) 88 // Attr wraps either an element/name, or a name/value pair (when it's a stan dalone Node.)
89 // Note that m_name is always set, but m_element/m_standaloneValue may be nu ll. 89 // Note that m_name is always set, but m_element/m_standaloneValue may be nu ll.
90 RawPtrWillBeMember<Element> m_element; 90 RawPtrWillBeMember<Element> m_element;
91 QualifiedName m_name; 91 QualifiedName m_name;
92 // Holds the value if it is a standalone Node, or the local name of the 92 // Holds the value if it is a standalone Node, or the local name of the
93 // attribute it is attached to on an Element. The latter may (letter case) 93 // attribute it is attached to on an Element. The latter may (letter case)
94 // differ from m_name's local name. As these two modes are non-overlapping, 94 // differ from m_name's local name. As these two modes are non-overlapping,
95 // use a single field. 95 // use a single field.
96 AtomicString m_standaloneValueOrAttachedLocalName; 96 AtomicString m_standaloneValueOrAttachedLocalName;
97 unsigned m_ignoreChildrenChanged; 97 unsigned m_ignoreChildrenChanged;
98 }; 98 };
99 99
100 DEFINE_NODE_TYPE_CASTS(Attr, isAttributeNode()); 100 DEFINE_NODE_TYPE_CASTS(Attr, isAttributeNode());
101 101
102 } // namespace WebCore 102 } // namespace WebCore
103 103
104 #endif // Attr_h 104 #endif // Attr_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/Attr.cpp » ('j') | Source/core/html/HTMLElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698