Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Side by Side Diff: Source/core/html/HTMLSelectElement.cpp

Issue 365673002: Pass a struct to ContainerNode::childrenChanged() instead of separate arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove dead code Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 } 385 }
386 386
387 void HTMLSelectElement::updateListItemSelectedStates() 387 void HTMLSelectElement::updateListItemSelectedStates()
388 { 388 {
389 if (!m_shouldRecalcListItems) 389 if (!m_shouldRecalcListItems)
390 return; 390 return;
391 recalcListItems(); 391 recalcListItems();
392 setNeedsValidityCheck(); 392 setNeedsValidityCheck();
393 } 393 }
394 394
395 void HTMLSelectElement::childrenChanged(bool changedByParser, Node* beforeChange , Node* afterChange, int childCountDelta) 395 void HTMLSelectElement::childrenChanged(const ChildrenChange& change)
396 { 396 {
397 setRecalcListItems(); 397 setRecalcListItems();
398 setNeedsValidityCheck(); 398 setNeedsValidityCheck();
399 m_lastOnChangeSelection.clear(); 399 m_lastOnChangeSelection.clear();
400 400
401 HTMLFormControlElementWithState::childrenChanged(changedByParser, beforeChan ge, afterChange, childCountDelta); 401 HTMLFormControlElementWithState::childrenChanged(change);
402 } 402 }
403 403
404 void HTMLSelectElement::optionElementChildrenChanged() 404 void HTMLSelectElement::optionElementChildrenChanged()
405 { 405 {
406 setRecalcListItems(); 406 setRecalcListItems();
407 setNeedsValidityCheck(); 407 setNeedsValidityCheck();
408 408
409 if (renderer()) { 409 if (renderer()) {
410 if (AXObjectCache* cache = renderer()->document().existingAXObjectCache( )) 410 if (AXObjectCache* cache = renderer()->document().existingAXObjectCache( ))
411 cache->childrenChanged(this); 411 cache->childrenChanged(this);
(...skipping 1246 matching lines...) Expand 10 before | Expand all | Expand 10 after
1658 1658
1659 void HTMLSelectElement::trace(Visitor* visitor) 1659 void HTMLSelectElement::trace(Visitor* visitor)
1660 { 1660 {
1661 #if ENABLE(OILPAN) 1661 #if ENABLE(OILPAN)
1662 visitor->trace(m_listItems); 1662 visitor->trace(m_listItems);
1663 #endif 1663 #endif
1664 HTMLFormControlElementWithState::trace(visitor); 1664 HTMLFormControlElementWithState::trace(visitor);
1665 } 1665 }
1666 1666
1667 } // namespace 1667 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698