Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Unified Diff: Source/core/html/canvas/WebGLActiveInfo.h

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have Nullable<T>::trace() use TraceIfNeeded<>. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGLActiveInfo.h
diff --git a/Source/core/html/canvas/WebGLActiveInfo.h b/Source/core/html/canvas/WebGLActiveInfo.h
index b02e0c78e35efff710f2c6bd02bbf58ea2180003..193bd33901db3c6a2e763899264d9d5151f2983d 100644
--- a/Source/core/html/canvas/WebGLActiveInfo.h
+++ b/Source/core/html/canvas/WebGLActiveInfo.h
@@ -34,16 +34,18 @@
namespace WebCore {
-class WebGLActiveInfo : public RefCounted<WebGLActiveInfo>, public ScriptWrappable {
+class WebGLActiveInfo FINAL : public RefCountedWillBeGarbageCollectedFinalized<WebGLActiveInfo>, public ScriptWrappable {
bajones 2014/07/18 20:31:29 This doesn't need to be Finalized, does it?
sof 2014/07/18 21:39:29 String gets in the way of that; it having a RefPtr
public:
- static PassRefPtr<WebGLActiveInfo> create(const String& name, GLenum type, GLint size)
+ static PassRefPtrWillBeRawPtr<WebGLActiveInfo> create(const String& name, GLenum type, GLint size)
{
- return adoptRef(new WebGLActiveInfo(name, type, size));
+ return adoptRefWillBeNoop(new WebGLActiveInfo(name, type, size));
}
String name() const { return m_name; }
GLenum type() const { return m_type; }
GLint size() const { return m_size; }
+ void trace(Visitor*) { }
+
private:
WebGLActiveInfo(const String& name, GLenum type, GLint size)
: m_name(name)

Powered by Google App Engine
This is Rietveld 408576698