Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: Source/core/html/canvas/WebGLBuffer.cpp

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have Nullable<T>::trace() use TraceIfNeeded<>. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGLBuffer.cpp
diff --git a/Source/core/html/canvas/WebGLBuffer.cpp b/Source/core/html/canvas/WebGLBuffer.cpp
index 6308eccf1922cc6d9b3322e0eec360307e87dc99..0dd42572ca28c15757feed56d48c7ca18aebf195 100644
--- a/Source/core/html/canvas/WebGLBuffer.cpp
+++ b/Source/core/html/canvas/WebGLBuffer.cpp
@@ -31,9 +31,9 @@
namespace WebCore {
-PassRefPtr<WebGLBuffer> WebGLBuffer::create(WebGLRenderingContextBase* ctx)
+PassRefPtrWillBeRawPtr<WebGLBuffer> WebGLBuffer::create(WebGLRenderingContextBase* ctx)
{
- return adoptRef(new WebGLBuffer(ctx));
+ return adoptRefWillBeNoop(new WebGLBuffer(ctx));
}
WebGLBuffer::WebGLBuffer(WebGLRenderingContextBase* ctx)
@@ -46,7 +46,7 @@ WebGLBuffer::WebGLBuffer(WebGLRenderingContextBase* ctx)
WebGLBuffer::~WebGLBuffer()
{
- deleteObject(0);
+ detachAndDeleteObject();
Ken Russell (switch to Gerrit) 2014/07/19 00:27:15 It's not obvious why we need to forcibly call deta
sof 2014/07/19 19:55:57 Yes, it definitely merits a comment; added a longe
}
void WebGLBuffer::deleteObjectImpl(blink::WebGraphicsContext3D* context3d, Platform3DObject object)

Powered by Google App Engine
This is Rietveld 408576698