Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.h

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/client_util.cc ('K') | « chrome/browser/google/google_update_settings_posix.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | chrome/common/child_process_logging_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/chrome_metrics_service_client.h
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.h b/chrome/browser/metrics/chrome_metrics_service_client.h
index a60960afe2f030364e9b049b2870bc23126d2783..578675631be0fdecf0df53c12d725eed3ac6b7cf 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.h
+++ b/chrome/browser/metrics/chrome_metrics_service_client.h
@@ -51,7 +51,7 @@ class ChromeMetricsServiceClient
static void RegisterPrefs(PrefRegistrySimple* registry);
// metrics::MetricsServiceClient:
- virtual void SetClientID(const std::string& client_id) OVERRIDE;
+ virtual void RegisterClientID(const std::string& client_id) OVERRIDE;
virtual bool IsOffTheRecordSessionActive() OVERRIDE;
virtual std::string GetApplicationLocale() OVERRIDE;
virtual bool GetBrand(std::string* brand_code) OVERRIDE;
« chrome/app/client_util.cc ('K') | « chrome/browser/google/google_update_settings_posix.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | chrome/common/child_process_logging_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698