chrome/common/child_process_logging_win.cc - Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/child_process_logging_win.cc

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/child_process_logging_win.cc

diff --git a/chrome/common/child_process_logging_win.cc b/chrome/common/child_process_logging_win.cc

index 1befb33b23a2eb971ddecee0e1c277a40b51e471..e072223913febd3fbca045fff51b545b42ef93af 100644

--- a/chrome/common/child_process_logging_win.cc

+++ b/chrome/common/child_process_logging_win.cc

@@ -67,10 +67,11 @@ void Init() {

// This would be handled by BreakpadClient::SetClientID(), but because of the

// aforementioned issue, crash keys aren't ready yet at the time of Breakpad

- // initialization.

+ // initialization, retrieve the client id backed up in Google Update settings

+ // instead.

std::string client_id;

Ilya Sherman 2014/07/08 03:21:38 nit: Should the variable name be updated here to i

gab 2014/07/08 18:42:22 Done.

- if (GoogleUpdateSettings::GetMetricsId(&client_id))

- base::debug::SetCrashKeyValue(crash_keys::kClientID, client_id);

+ if (GoogleUpdateSettings::RetrieveMetricsID(&client_id))

+ crash_keys::SetClientIDFromGUID(client_id);

}

} // namespace child_process_logging

« chrome/app/client_util.cc ('K') | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | chrome/common/crash_keys.h » ('j') | chrome/common/crash_keys.cc » ('J')