chrome/app/client_util.cc - Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/client_util.cc

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/chrome_breakpad_client.cc ('K') | « chrome/app/chrome_breakpad_client.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | chrome/common/child_process_logging_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/client_util.cc

diff --git a/chrome/app/client_util.cc b/chrome/app/client_util.cc

index e8c0900abde0030287c93e5815251730be6bad67..96295dcdd39d7c59c7519898ba15c8067142c3a4 100644

--- a/chrome/app/client_util.cc

+++ b/chrome/app/client_util.cc

@@ -76,7 +76,7 @@ void GetPreReadPopulationAndGroup(double* population, double* group) {

// By default we use the metrics id for the user as stable pseudo-random

// input to a hash.

std::string metrics_id;

- GoogleUpdateSettings::GetMetricsId(&metrics_id);

+ GoogleUpdateSettings::RetrieveMetricsID(&metrics_id);

Ilya Sherman 2014/07/08 03:21:38 Optional nit: IMO "Get" and "Retrieve" are synonym

gab 2014/07/08 18:42:22 Went with Load/Store as suggested by grt @ https:/

// If this user has not metrics id, we fall back to a purely random value

// per browser session.