chrome/app/chrome_breakpad_client.cc - Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_breakpad_client.cc

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_breakpad_client.cc

diff --git a/chrome/app/chrome_breakpad_client.cc b/chrome/app/chrome_breakpad_client.cc

index 09cf2fab1128845fada0fa5331576e714279a071..aa8e84c6a004894ef0a6daaecd49a9629f4640ec 100644

--- a/chrome/app/chrome_breakpad_client.cc

+++ b/chrome/app/chrome_breakpad_client.cc

@@ -80,8 +80,8 @@ ChromeBreakpadClient::ChromeBreakpadClient() {}

ChromeBreakpadClient::~ChromeBreakpadClient() {}

-void ChromeBreakpadClient::SetClientID(const std::string& client_id) {

- crash_keys::SetClientID(client_id);

+void ChromeBreakpadClient::InitClientID(const std::string& client_id) {

Ilya Sherman 2014/07/08 03:21:38 nit: Should the variable be renamed to include "gu

gab 2014/07/08 18:42:22 Done.

+ crash_keys::SetClientIDFromGUID(client_id);

}

#if defined(OS_WIN)

« no previous file with comments | « chrome/app/chrome_breakpad_client.h ('k') | chrome/app/client_util.cc » ('j') | chrome/app/client_util.cc » ('J')