Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set

chrome/app/chrome_breakpad_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/chrome_breakpad_client.h"
 
 #include "base/atomicops.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/files/file_path.h"
@@ skipping 62 matching lines @@
 // A atomic counter to make each crash dump value name unique.
 base::subtle::Atomic32 g_browser_crash_dump_count = 0;
 #endif
 
 }  // namespace
 
 ChromeBreakpadClient::ChromeBreakpadClient() {}
 
 ChromeBreakpadClient::~ChromeBreakpadClient() {}
 
-void ChromeBreakpadClient::SetClientID(const std::string& client_id) {
-  crash_keys::SetClientID(client_id);
+void ChromeBreakpadClient::InitClientID(const std::string& client_id) {

[Ilya Sherman, 2014/07/08 03:21:38]

nit: Should the variable be renamed to include "guid" in the name as well?

[gab, 2014/07/08 18:42:22]

Done.

+  crash_keys::SetClientIDFromGUID(client_id);
 }
 
 #if defined(OS_WIN)
 bool ChromeBreakpadClient::GetAlternativeCrashDumpLocation(
     base::FilePath* crash_dir) {
   // By setting the BREAKPAD_DUMP_LOCATION environment variable, an alternate
   // location to write breakpad crash dumps can be set.
   scoped_ptr<base::Environment> env(base::Environment::Create());
   std::string alternate_crash_dump_location;
   if (env->GetVar("BREAKPAD_DUMP_LOCATION", &alternate_crash_dump_location)) {
@@ skipping 272 matching lines @@
 bool ChromeBreakpadClient::EnableBreakpadForProcess(
     const std::string& process_type) {
   return process_type == switches::kRendererProcess ||
          process_type == switches::kPluginProcess ||
          process_type == switches::kPpapiPluginProcess ||
          process_type == switches::kZygoteProcess ||
          process_type == switches::kGpuProcess;
 }
 
 }  // namespace chrome