Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: net/socket/ssl_client_socket_openssl.h

Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved documentation and switched to use a temp var of the task_runner. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_openssl.cc » ('j') | net/socket/ssl_client_socket_pool.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_openssl.h
diff --git a/net/socket/ssl_client_socket_openssl.h b/net/socket/ssl_client_socket_openssl.h
index f18eec5874eb50422b0dd28eec163db85e99eb68..f53f017e9ae280e6eb2b3437d1a170337b35d18f 100644
--- a/net/socket/ssl_client_socket_openssl.h
+++ b/net/socket/ssl_client_socket_openssl.h
@@ -222,6 +222,8 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {
ServerBoundCertService* server_bound_cert_service_;
// Callback that is invoked when the connection encounters an error.
+ // This callback should be run regardless of whether or not this socket
+ // will still be valid at its runtime.
Ryan Sleevi 2014/07/10 20:30:45 Sorry that it seems like I still wasn't clear. Th
mshelley 2014/07/10 22:49:58 Done.
base::Closure error_callback_;
// True if there may be pending sockets waiting for this socket to connect.
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_openssl.cc » ('j') | net/socket/ssl_client_socket_pool.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698