Makes waiting SSLConnectJobs use the message loops to resume their connection.

net/socket/ssl_client_socket_openssl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_OPENSSL_H_
 #define NET_SOCKET_SSL_CLIENT_SOCKET_OPENSSL_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 204 matching lines @@
   // server.
   std::vector<SSLClientCertType> cert_key_types_;
 
   CertVerifier* const cert_verifier_;
   scoped_ptr<SingleRequestCertVerifier> verifier_;
 
   // The service for retrieving Channel ID keys.  May be NULL.
   ServerBoundCertService* server_bound_cert_service_;
 
   // Callback that is invoked when the connection encounters an error.
+  // This callback should be run regardless of whether or not this socket
+  // will still be valid at its runtime.

[Ryan Sleevi, 2014/07/10 20:30:45]

Sorry that it seems like I still wasn't clear.

The caller/user of the SSLClientSocket should never have to read to the data
members - that's documentation for the implementer/coder

What matters is the documentation on the public methods; in particular,
SetSocketFailureCallback (on the base class)

[mshelley, 2014/07/10 22:49:58]

Done.

   base::Closure error_callback_;
 
   // True if there may be pending sockets waiting for this socket to connect.
   bool is_leader_;
 
   // OpenSSL stuff
   SSL* ssl_;
   BIO* transport_bio_;
 
   scoped_ptr<ClientSocketHandle> transport_;
@@ skipping 25 matching lines @@
   // True if channel ID extension was negotiated.
   bool channel_id_xtn_negotiated_;
   // The request handle for |server_bound_cert_service_|.
   ServerBoundCertService::RequestHandle channel_id_request_handle_;
   BoundNetLog net_log_;
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_CLIENT_SOCKET_OPENSSL_H_