Makes waiting SSLConnectJobs use the message loops to resume their connection.

net/socket/ssl_client_socket_pool.h

Index: net/socket/ssl_client_socket_pool.h
diff --git a/net/socket/ssl_client_socket_pool.h b/net/socket/ssl_client_socket_pool.h
index 1f43e95f534452721f2acebd2dda5ca3d0829044..87b1212995dffe3c212806d44325c55a6c72ec99 100644
--- a/net/socket/ssl_client_socket_pool.h
+++ b/net/socket/ssl_client_socket_pool.h
@@ -116,6 +116,8 @@ class NET_EXPORT_PRIVATE SSLConnectJobMessenger {
 
   typedef std::vector<SocketAndCallback> SSLPendingSocketsAndCallbacks;
 
+  SSLConnectJobMessenger();
+
   // Returns true if the given |ssl_socket| should continue its
   // SSL connection.

[Ryan Sleevi, 2014/07/10 20:30:45]

unrelated to this CL: (not sure which CL is the master for this, or if this has
landed, with all the CLs flying about)

// Returns true if |ssl_socket|'s Connect() method should be called.

[mshelley, 2014/07/10 22:49:59]

Done.

   bool CanProceed(SSLClientSocket* ssl_socket);
@@ -132,14 +134,20 @@ class NET_EXPORT_PRIVATE SSLConnectJobMessenger {
   // its connection.
   void OnJobSucceeded();
 
-  // Processes pending callbacks when a socket encounters an error
+  // Posts a task to process pending callbacks when a socket encounters an error
   // while completing its connection.
   void OnJobFailed();

[Ryan Sleevi, 2014/07/10 20:30:45]

note: OnJobSucceeded and OnJobFailed both seem to only be used in base::Bind()
calls.

In that case, these methods should be private.

The same seems to be true for ConnectNewLeader (which is called by OnJobFailed)

[mshelley, 2014/07/10 22:49:59]

OnJobFailed is called once directly in DoSSLConenctComplete, but I'll make the
others private.

 
+  // Determines which pending socket should be the next leading connection,
+  // and runs that socket's resumption callback.
+  void ConnectNewLeader();
+
  private:
   // Runs all callbacks stored in |pending_sockets_and_callbacks_|.
-  void RunAllJobs(std::vector<SocketAndCallback>& pending_socket_and_callbacks);
+  void RunAllJobs(
+      std::vector<SocketAndCallback>& pending_sockets_and_callbacks);
 
+  base::WeakPtrFactory<SSLConnectJobMessenger> weak_factory_;
   SSLPendingSocketsAndCallbacks pending_sockets_and_callbacks_;
   std::vector<SSLClientSocket*> connecting_sockets_;
 };