Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 36473003: Rename StackingClient -> WindowTreeClient (Closed)

Created:
7 years, 2 months ago by Ben Goodger (Google)
Modified:
7 years, 2 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, joi+watch-content_chromium.org, sadrul, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, ben+aura_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, ben+corewm_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su, ben+views_chromium.org, ben+ash_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Rename StackingClient -> WindowTreeClient Remove SetDefaultParentForRootWindow from Window, and replace with new utility function ParentWindowForContext in window_tree_client.h This is part of my current campaign to slim down the aura Window types. I will eventually move WindowTreeClient to a new ui/wm component that I plan to create. R=erg@chromium.org http://crbug.com/308844 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230501

Patch Set 1 #

Patch Set 2 : done. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -333 lines) Patch
M ash/display/screen_position_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/header_painter_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M ash/wm/stacking_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/stacking_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/stacking_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/apps/native_app_window_views.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 7 chunks +24 lines, -12 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura/aura.gyp View 1 3 chunks +4 lines, -4 lines 0 comments Download
D ui/aura/client/stacking_client.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/aura/client/stacking_client.cc View 1 chunk +0 lines, -38 lines 0 comments Download
A ui/aura/client/window_tree_client.h View 1 chunk +56 lines, -0 lines 0 comments Download
A ui/aura/client/window_tree_client.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 5 chunks +16 lines, -15 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D ui/aura/test/test_stacking_client.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/aura/test/test_stacking_client.cc View 1 chunk +0 lines, -28 lines 0 comments Download
A ui/aura/test/test_window_tree_client.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
A ui/aura/test/test_window_tree_client.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M ui/aura/window.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M ui/aura/window.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 7 chunks +6 lines, -11 lines 0 comments Download
M ui/shell/minimal_shell.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/shell/minimal_shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/shadow_controller_unittest.cc View 1 9 chunks +9 lines, -8 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 5 chunks +13 lines, -12 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
7 years, 2 months ago (2013-10-23 18:29:03 UTC) #1
Elliot Glaysher
lgtm
7 years, 2 months ago (2013-10-23 19:54:03 UTC) #2
Ben Goodger (Google)
7 years, 2 months ago (2013-10-23 20:44:58 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r230501 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698