Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 364653003: ARM64: Reland faster immediate check (Closed)

Created:
6 years, 5 months ago by m.m.capewell
Modified:
6 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM64: Reland faster immediate check Improve the code used to check for encodable logical immediates, fix some corner cases associated with moving kWMinInt into W registers, and add tests. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -73 lines) Patch
M src/arm64/assembler-arm64.cc View 2 chunks +183 lines, -67 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M src/arm64/utils-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/utils-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 6 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
m.m.capewell
Try server reports success, so this shouldn't cause problems this time.
6 years, 5 months ago (2014-07-01 16:56:25 UTC) #1
ulan
lgtm
6 years, 5 months ago (2014-07-02 06:42:51 UTC) #2
m.m.capewell
6 years, 5 months ago (2014-07-02 09:52:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22148 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698