Add a basic Mojo SerialService that implements GetDevices().

Add a basic Mojo SerialService that implements GetDevices().

BUG=389016
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282012

[Ken Rockot(use gerrit already), 2014-07-02 15:22:10]

lgtm pending the namespace change from r280993

[raymes, 2014-07-03 00:04:47]

It seems like it would be good to have some sort of review process for
the .mojom files to ensure that we have some consistency APIs. It may
be a very lightweight process to begin with since the APIs are used
only internally within Chrome.

Darin, do you have any thoughts on this? Maybe an lgtm from someone on
mojo team is good enough for now? Can we have (do we want) an OWNERS
file for *.mojom?

On Thu, Jul 3, 2014 at 1:22 AM,  <rockot@chromium.org> wrote:
> lgtm pending the namespace change from r280993
>
> https://codereview.chromium.org/363853003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[darin (slow to review), 2014-07-03 07:23:51]

We should discuss on mojo-dev@, but briefly I can see pros and cons. For
public APIs, we definitely need a formal review process. For private APIs,
it seems the review can be lighter weight. At minimum, we probably just
need a security review similar to changes made to *messages.h files.
However, since mojom is an interesting new language maybe there is some
measure of tighter design review warranted for private APIs, at least while
we are still making big changes to the core design and finding the API
patterns & style.
On Jul 2, 2014 5:04 PM, "Raymes Khoury" <raymes@chromium.org> wrote:

> It seems like it would be good to have some sort of review process for
> the .mojom files to ensure that we have some consistency APIs. It may
> be a very lightweight process to begin with since the APIs are used
> only internally within Chrome.
>
> Darin, do you have any thoughts on this? Maybe an lgtm from someone on
> mojo team is good enough for now? Can we have (do we want) an OWNERS
> file for *.mojom?
>
> On Thu, Jul 3, 2014 at 1:22 AM,  <rockot@chromium.org> wrote:
> > lgtm pending the namespace change from r280993
> >
> > https://codereview.chromium.org/363853003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sam McNally, 2014-07-08 09:14:04]

+darin for mojom review
+tsepez for security

[Tom Sepez, 2014-07-08 17:43:14]

On 2014/07/08 09:14:04, Sam McNally wrote:
> +darin for mojom review
> +tsepez for security

Out til the 14th.  Can this wait?

[darin (slow to review), 2014-07-08 21:20:15]

LGTM

This doesn't expose new information to sandboxed processes (yet)! Also, the
Mojom interfaces are consistent with corresponding data exposed via Extensions
JSON Schema.

Sam, I think you can TBR this tsepez or at least only block on his review when
you are ready to finally expose this Mojo interface to a sandboxed renderer.

[Sam McNally, 2014-07-09 00:13:01]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-07-09 00:15:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/363853003/140001

[Sam McNally, 2014-07-09 01:15:26]

The CQ bit was unchecked by sammc@chromium.org

[Sam McNally, 2014-07-09 01:24:10]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-07-09 01:26:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/363853003/180001

[commit-bot: I haz the power, 2014-07-09 07:02:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-09 09:58:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-09 09:58:56]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Sam McNally, 2014-07-09 10:16:22]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2014-07-09 10:17:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sammc@chromium.org/363853003/180001

[commit-bot: I haz the power, 2014-07-09 13:04:29]

Change committed as 282012