device/serial/serial_device_enumerator_linux.cc - Issue 363853003: Add a basic Mojo SerialService that implements GetDevices().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/serial_device_enumerator_linux.cc

Issue 363853003: Add a basic Mojo SerialService that implements GetDevices(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/serial/serial_device_enumerator_linux.cc

diff --git a/device/serial/serial_device_enumerator_linux.cc b/device/serial/serial_device_enumerator_linux.cc

index 3d3097d5ecdadb806e3b46b77db2e256b7250843..f2fb9fac6779cf33a6a832ac31fc1805293e31b3 100644

--- a/device/serial/serial_device_enumerator_linux.cc

+++ b/device/serial/serial_device_enumerator_linux.cc

@@ -45,7 +45,7 @@ SerialDeviceEnumeratorLinux::SerialDeviceEnumeratorLinux() {

SerialDeviceEnumeratorLinux::~SerialDeviceEnumeratorLinux() {}

mojo::Array<serial::DeviceInfoPtr> SerialDeviceEnumeratorLinux::GetDevices() {

- mojo::Array<serial::DeviceInfoPtr> devices;

+ mojo::Array<serial::DeviceInfoPtr> devices(0);

ScopedUdevEnumeratePtr enumerate(udev_enumerate_new(udev_.get()));

if (!enumerate) {

LOG(ERROR) << "Serial device enumeration failed.";

« no previous file with comments | « device/serial/serial.mojom ('k') | device/serial/serial_device_enumerator_mac.cc » ('j') | no next file with comments »