device/serial/serial_device_enumerator_win.cc - Issue 363853003: Add a basic Mojo SerialService that implements GetDevices().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/serial_device_enumerator_win.cc

Issue 363853003: Add a basic Mojo SerialService that implements GetDevices(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/serial/serial_device_enumerator_win.cc

diff --git a/device/serial/serial_device_enumerator_win.cc b/device/serial/serial_device_enumerator_win.cc

index 2e9e5876bdd98adfd71d05e4d5903d2b3efb7203..124c6b720466909d811e86384d65f2c616de8596 100644

--- a/device/serial/serial_device_enumerator_win.cc

+++ b/device/serial/serial_device_enumerator_win.cc

@@ -29,7 +29,7 @@ SerialDeviceEnumeratorWin::~SerialDeviceEnumeratorWin() {}

mojo::Array<serial::DeviceInfoPtr> SerialDeviceEnumeratorWin::GetDevices() {

base::win::RegistryValueIterator iter_key(

HKEY_LOCAL_MACHINE, L"HARDWARE\\DEVICEMAP\\SERIALCOMM\\");

- mojo::Array<serial::DeviceInfoPtr> devices;

+ mojo::Array<serial::DeviceInfoPtr> devices(0);

for (; iter_key.Valid(); ++iter_key) {

serial::DeviceInfoPtr info(serial::DeviceInfo::New());

info->path = base::UTF16ToASCII(iter_key.Value());

« no previous file with comments | « device/serial/serial_device_enumerator_mac.cc ('k') | device/serial/serial_service_impl.h » ('j') | no next file with comments »