Add more GN deps to the build.

Add more GN deps to the build.

These deps are some of those required to compile chrome/browser (so mostly those containing resources and protobufs that have generated headers). chrome/browser still has some dependencies left.

Add third_party libs libaddressinput and dom_distiller_js.

Add components dom_distiller and policy.

Separate the generate_library_loader into a separate .gni file.

Rename components_strings to just strings.

R=ajwong@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280916

[awong, 2014-07-01 21:47:11]

Couple of nits, but mostly looking good

https://codereview.chromium.org/362583002/diff/60001/chrome/app/BUILD.gn
File chrome/app/BUILD.gn (right):

https://codereview.chromium.org/362583002/diff/60001/chrome/app/BUILD.gn#newc...
chrome/app/BUILD.gn:24: rebase_path(outputs, root_build_dir)
Should this be a 4 space indent for line continuation? (unsure)

https://codereview.chromium.org/362583002/diff/60001/components/dom_distiller...
File components/dom_distiller/core/BUILD.gn (right):

https://codereview.chromium.org/362583002/diff/60001/components/dom_distiller...
components/dom_distiller/core/BUILD.gn:57: #deps += [
":dom_distiller_core_jni_headers" ]  TODO(GYP)
Can you put the # on the first column? Much easier to visually notice.

https://codereview.chromium.org/362583002/diff/60001/components/dom_distiller...
components/dom_distiller/core/BUILD.gn:74:
#'components.gyp:leveldb_proto_test_support',  TODO(GYP)
Same here...put these temporary comments on the first column?

https://codereview.chromium.org/362583002/diff/60001/third_party/libaddressin...
File third_party/libaddressinput/libaddressinput.gyp (right):

https://codereview.chromium.org/362583002/diff/60001/third_party/libaddressin...
third_party/libaddressinput/libaddressinput.gyp:177: # GN version:
//third_party/libaddressinput:libaddressinput_unittests
Are add a comment now to tag each gyp target with the corresponding GN target
even if there are no surprises in the new target name?

https://codereview.chromium.org/362583002/diff/60001/tools/generate_library_l...
File tools/generate_library_loader/generate_library_loader.gni (right):

https://codereview.chromium.org/362583002/diff/60001/tools/generate_library_l...
tools/generate_library_loader/generate_library_loader.gni:5: # name: Name to use
for the value of the --name arg.
Can we add a sentence or two explaining what as library_loader is and why you'd
use this template?

[brettw, 2014-07-01 23:26:27]

new snap up

https://codereview.chromium.org/362583002/diff/60001/components/dom_distiller...
File components/dom_distiller/core/BUILD.gn (right):

https://codereview.chromium.org/362583002/diff/60001/components/dom_distiller...
components/dom_distiller/core/BUILD.gn:57: #deps += [
":dom_distiller_core_jni_headers" ]  TODO(GYP)
On 2014/07/01 21:47:11, awong wrote:
> Can you put the # on the first column? Much easier to visually notice.

I haven't been doing that and I find it makes the files harder to follow. When
I'm looking for stuff I grep for TODO(GYP) rather than random scanning.

https://codereview.chromium.org/362583002/diff/60001/third_party/libaddressin...
File third_party/libaddressinput/libaddressinput.gyp (right):

https://codereview.chromium.org/362583002/diff/60001/third_party/libaddressin...
third_party/libaddressinput/libaddressinput.gyp:177: # GN version:
//third_party/libaddressinput:libaddressinput_unittests
On 2014/07/01 21:47:11, awong wrote:
> Are add a comment now to tag each gyp target with the corresponding GN target
> even if there are no surprises in the new target name?

Yes, so you can tell that it exists.

https://codereview.chromium.org/362583002/diff/60001/tools/generate_library_l...
File tools/generate_library_loader/generate_library_loader.gni (right):

https://codereview.chromium.org/362583002/diff/60001/tools/generate_library_l...
tools/generate_library_loader/generate_library_loader.gni:5: # name: Name to use
for the value of the --name arg.
On 2014/07/01 21:47:11, awong wrote:
> Can we add a sentence or two explaining what as library_loader is and why
you'd
> use this template?

I added a brief one. I don't actually know any more than what I added.

[awong, 2014-07-01 23:30:46]

LGTM

https://codereview.chromium.org/362583002/diff/60001/tools/generate_library_l...
File tools/generate_library_loader/generate_library_loader.gni (right):

https://codereview.chromium.org/362583002/diff/60001/tools/generate_library_l...
tools/generate_library_loader/generate_library_loader.gni:5: # name: Name to use
for the value of the --name arg.
On 2014/07/01 23:26:27, brettw wrote:
> On 2014/07/01 21:47:11, awong wrote:
> > Can we add a sentence or two explaining what as library_loader is and why
> you'd
> > use this template?
> 
> I added a brief one. I don't actually know any more than what I added.

Huh...looking at this file more closely, it feels like we have duplicated
functionality between this an generate_sigs. Ah well. Whatever.

Thanks for the comment.

[brettw, 2014-07-01 23:54:24]

Committed patchset #8 manually as r280916.