Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/app/BUILD.gn

Issue 362583002: Add more GN deps to the build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/BUILD.gn
diff --git a/chrome/app/BUILD.gn b/chrome/app/BUILD.gn
index 2addc7ba045966075b096f07efc74f85d28cd55e..9ff5c084652ad0f47f6a393ddccba5982b1650a3 100644
--- a/chrome/app/BUILD.gn
+++ b/chrome/app/BUILD.gn
@@ -10,6 +10,29 @@ grit("generated_resources") {
source = "generated_resources.grd"
}
+# GYP version: chrome/chrome_resources.gyp:chrome_strings_map
+action("make_generated_resources_map") {
+ # Targets should depend on generated_resources_map instead.
+ visibility = ":generated_resources_map"
+
+ script = "//chrome/browser/metrics/variations/generate_resources_map.py"
+
+ source_prereqs = [ "$target_gen_dir/grit/generated_resources.h" ]
+ outputs = [ "$target_gen_dir/generated_resources_map.cc" ]
+
+ args = rebase_path(source_prereqs, root_build_dir) +
+ rebase_path(outputs, root_build_dir)
+
+ deps = [ ":generated_resources" ]
+}
+
+# Collect the generated .cc file from make_generated_resources_map and put it
+# in a source set so targets that depend on it will link the source rather than
+# specifying it manually. This doesn't happen in the GYP build.
+source_set("generated_resources_map") {
+ sources = get_target_outputs(":make_generated_resources_map")
+}
+
# GYP version: chrome/chrome_resources.gyp:chrome_strings
# (generate_google_chrome_strings action)
grit("google_chrome_strings") {
« no previous file with comments | « build/secondary/third_party/cacheinvalidation/src/google/cacheinvalidation/BUILD.gn ('k') | chrome/app/theme/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698