Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: third_party/libaddressinput/libaddressinput.gyp

Issue 362583002: Add more GN deps to the build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix libaddressinput include path Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 # TODO(rouslan): Use the src/ directory. http://crbug.com/327046 6 # TODO(rouslan): Use the src/ directory. http://crbug.com/327046
7 'libaddressinput_dir': 'chromium', 7 'libaddressinput_dir': 'chromium',
8 }, 8 },
9 'target_defaults': { 9 'target_defaults': {
10 'conditions': [ 10 'conditions': [
11 ['OS=="mac" or OS=="ios"', { 11 ['OS=="mac" or OS=="ios"', {
12 'xcode_settings': { 12 'xcode_settings': {
13 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'NO', 13 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'NO',
14 }, 14 },
15 }], 15 }],
16 ], 16 ],
17 'defines': [ 17 'defines': [
18 'CUSTOM_BASICTYPES="base/basictypes.h"', 18 'CUSTOM_BASICTYPES="base/basictypes.h"',
19 'CUSTOM_SCOPED_PTR="base/memory/scoped_ptr.h"', 19 'CUSTOM_SCOPED_PTR="base/memory/scoped_ptr.h"',
20 ], 20 ],
21 }, 21 },
22 'targets': [ 22 'targets': [
23 { 23 {
24 # GN version: //third_party/libaddressinput:strings
24 'target_name': 'libaddressinput_strings', 25 'target_name': 'libaddressinput_strings',
25 'type': 'none', 26 'type': 'none',
26 'variables': { 27 'variables': {
27 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/third_party/libaddressinput/ ', 28 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/third_party/libaddressinput/ ',
28 }, 29 },
29 'actions': [ 30 'actions': [
30 { 31 {
31 'action_name': 'libaddressinput_strings', 32 'action_name': 'libaddressinput_strings',
32 'variables': { 33 'variables': {
33 'grit_grd_file': '<(libaddressinput_dir)/cpp/res/libaddressinput_str ings.grd', 34 'grit_grd_file': '<(libaddressinput_dir)/cpp/res/libaddressinput_str ings.grd',
34 }, 35 },
35 'includes': [ 36 'includes': [
36 '../../build/grit_action.gypi', 37 '../../build/grit_action.gypi',
37 ], 38 ],
38 }, 39 },
39 ], 40 ],
40 'includes': [ 41 'includes': [
41 '../../build/grit_target.gypi', 42 '../../build/grit_target.gypi',
42 ], 43 ],
43 }, 44 },
44 { 45 {
46 # GN version: //third_party/libaddressinput:updated_strings
45 'target_name': 'libaddressinput_updated_strings', 47 'target_name': 'libaddressinput_updated_strings',
46 'type': 'none', 48 'type': 'none',
47 'variables': { 49 'variables': {
48 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/grit/libaddressinput/', 50 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/grit/libaddressinput/',
49 }, 51 },
50 'actions': [ 52 'actions': [
51 { 53 {
52 'action_name': 'libaddressinput_updated_strings', 54 'action_name': 'libaddressinput_updated_strings',
53 'variables': { 55 'variables': {
54 'grit_grd_file': '../../chrome/app/address_input_strings.grd', 56 'grit_grd_file': '../../chrome/app/address_input_strings.grd',
55 }, 57 },
56 'includes': [ 58 'includes': [
57 '../../build/grit_action.gypi', 59 '../../build/grit_action.gypi',
58 ], 60 ],
59 }, 61 },
60 ], 62 ],
61 'includes': [ 63 'includes': [
62 '../../build/grit_target.gypi', 64 '../../build/grit_target.gypi',
63 ], 65 ],
64 }, 66 },
65 # This target provides basic functionality which is cooked into the build. 67 # This target provides basic functionality which is cooked into the build.
66 { 'target_name': 'libaddressinput_util', 68 {
69 # GN version: //third_party/libaddressinput:util
70 'target_name': 'libaddressinput_util',
67 'type': 'static_library', 71 'type': 'static_library',
68 'include_dirs': [ 72 'include_dirs': [
69 '<(libaddressinput_dir)/cpp/include/', 73 '<(libaddressinput_dir)/cpp/include/',
70 '<(SHARED_INTERMEDIATE_DIR)/libaddressinput/', 74 '<(SHARED_INTERMEDIATE_DIR)/libaddressinput/',
71 ], 75 ],
72 'sources': [ 76 'sources': [
73 'chromium/canonicalize_string.cc', 77 'chromium/canonicalize_string.cc',
74 'chromium/json.cc', 78 'chromium/json.cc',
75 '<(libaddressinput_dir)/cpp/include/libaddressinput/address_data.h', 79 '<(libaddressinput_dir)/cpp/include/libaddressinput/address_data.h',
76 '<(libaddressinput_dir)/cpp/include/libaddressinput/address_field.h', 80 '<(libaddressinput_dir)/cpp/include/libaddressinput/address_field.h',
(...skipping 28 matching lines...) Expand all
105 'CUSTOM_SCOPED_PTR="base/memory/scoped_ptr.h"', 109 'CUSTOM_SCOPED_PTR="base/memory/scoped_ptr.h"',
106 ], 110 ],
107 'include_dirs': [ 111 'include_dirs': [
108 '<(libaddressinput_dir)/cpp/include/', 112 '<(libaddressinput_dir)/cpp/include/',
109 ], 113 ],
110 }, 114 },
111 }, 115 },
112 # This target provides more complicated functionality like pinging servers 116 # This target provides more complicated functionality like pinging servers
113 # for validation rules. 117 # for validation rules.
114 { 118 {
119 # GN version: //third_party/libaddressinput
115 'target_name': 'libaddressinput', 120 'target_name': 'libaddressinput',
116 'type': 'static_library', 121 'type': 'static_library',
117 'include_dirs': [ 122 'include_dirs': [
118 '<(libaddressinput_dir)/cpp/include/', 123 '<(libaddressinput_dir)/cpp/include/',
119 '<(SHARED_INTERMEDIATE_DIR)/libaddressinput/', 124 '<(SHARED_INTERMEDIATE_DIR)/libaddressinput/',
120 ], 125 ],
121 'sources': [ 126 'sources': [
122 'chromium/chrome_downloader_impl.cc', 127 'chromium/chrome_downloader_impl.cc',
123 'chromium/chrome_downloader_impl.h', 128 'chromium/chrome_downloader_impl.h',
124 'chromium/chrome_storage_impl.cc', 129 'chromium/chrome_storage_impl.cc',
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 'defines': [ 167 'defines': [
163 'CUSTOM_BASICTYPES="base/basictypes.h"', 168 'CUSTOM_BASICTYPES="base/basictypes.h"',
164 'CUSTOM_SCOPED_PTR="base/memory/scoped_ptr.h"', 169 'CUSTOM_SCOPED_PTR="base/memory/scoped_ptr.h"',
165 ], 170 ],
166 'include_dirs': [ 171 'include_dirs': [
167 '<(libaddressinput_dir)/cpp/include/', 172 '<(libaddressinput_dir)/cpp/include/',
168 ], 173 ],
169 }, 174 },
170 }, 175 },
171 { 176 {
177 # GN version: //third_party/libaddressinput:libaddressinput_unittests
awong 2014/07/01 21:47:11 Are add a comment now to tag each gyp target with
brettw 2014/07/01 23:26:27 Yes, so you can tell that it exists.
172 'target_name': 'libaddressinput_unittests', 178 'target_name': 'libaddressinput_unittests',
173 'type': '<(gtest_target_type)', 179 'type': '<(gtest_target_type)',
174 'include_dirs': [ 180 'include_dirs': [
175 '<(DEPTH)', 181 '<(DEPTH)',
176 '<(libaddressinput_dir)/cpp/src/', 182 '<(libaddressinput_dir)/cpp/src/',
177 '<(DEPTH)/testing/gtest/include/', 183 '<(DEPTH)/testing/gtest/include/',
178 '<(SHARED_INTERMEDIATE_DIR)/libaddressinput/', 184 '<(SHARED_INTERMEDIATE_DIR)/libaddressinput/',
179 ], 185 ],
180 'sources': [ 186 'sources': [
181 'chromium/chrome_downloader_impl_unittest.cc', 187 'chromium/chrome_downloader_impl_unittest.cc',
(...skipping 30 matching lines...) Expand all
212 'libaddressinput', 218 'libaddressinput',
213 'libaddressinput_strings', 219 'libaddressinput_strings',
214 '<(DEPTH)/base/base.gyp:base_prefs', 220 '<(DEPTH)/base/base.gyp:base_prefs',
215 '<(DEPTH)/base/base.gyp:run_all_unittests', 221 '<(DEPTH)/base/base.gyp:run_all_unittests',
216 '<(DEPTH)/net/net.gyp:net_test_support', 222 '<(DEPTH)/net/net.gyp:net_test_support',
217 '<(DEPTH)/testing/gtest.gyp:gtest', 223 '<(DEPTH)/testing/gtest.gyp:gtest',
218 ], 224 ],
219 }, 225 },
220 ], 226 ],
221 } 227 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698