Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 362133003: Revert of Refactoring activity logger

Created:
6 years, 5 months ago by eseidel
Modified:
6 years, 3 months ago
Reviewers:
haraken, pmarch
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, watchdog-blink-watchlist_google.com, rwlbuis, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Refactoring activity logger (https://codereview.chromium.org/367483005/) Reason for revert: This is the leading candidate for the "uncaught illegal access" console log failures in animation tests which started around the time of this commit. Original issue's description: > Enable logging of page redirections. > > BUG=388287 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177320 TBR=haraken@chromium.org,pfeldman@chromium.org,pmarch@chromium.org NOTREECHECKS=true NOTRY=true BUG=388287, 390732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -42 lines) Patch
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/frame/Location.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ActivityLoggerTest.cpp View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
eseidel
Created Revert of Refactoring activity logger
6 years, 5 months ago (2014-07-02 00:14:53 UTC) #1
eseidel
The CQ bit was unchecked by eseidel@chromium.org
6 years, 5 months ago (2014-07-02 00:15:19 UTC) #2
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 5 months ago (2014-07-02 00:15:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/362133003/1
6 years, 5 months ago (2014-07-02 00:16:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 00:16:08 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/web/tests/ActivityLoggerTest.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-02 00:16:09 UTC) #6
pmarch
On 2014/07/02 00:16:09, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 5 months ago (2014-07-03 15:32:11 UTC) #7
pmarch
6 years, 5 months ago (2014-07-03 15:33:01 UTC) #8 
On 2014/07/03 15:32:11, pmarch wrote:
> On 2014/07/02 00:16:09, I haz the power (commit-bot) wrote:
> > Failed to apply patch for Source/web/tests/ActivityLoggerTest.cpp:
> > While running patch -p1 --forward --force --no-backup-if-mismatch;
> >   patching file Source/web/tests/ActivityLoggerTest.cpp
> >   Hunk #1 FAILED at 433.
> >   1 out of 1 hunk FAILED -- saving rejects to file
> > Source/web/tests/ActivityLoggerTest.cpp.rej
> > 
> > Patch:       Source/web/tests/ActivityLoggerTest.cpp
> > Index: Source/web/tests/ActivityLoggerTest.cpp
> > diff --git a/Source/web/tests/ActivityLoggerTest.cpp
> > b/Source/web/tests/ActivityLoggerTest.cpp
> > index
> >
>
511a6d7199925a2722c2db043c8feb0c1108383a..ff4bafed2aad857c88b68ab330e5bfe84b9c9e3c
> > 100644
> > --- a/Source/web/tests/ActivityLoggerTest.cpp
> > +++ b/Source/web/tests/ActivityLoggerTest.cpp
> > @@ -433,30 +433,4 @@
> >      ASSERT_TRUE(verifyActivities(expectedActivities));
> >  }
> >  
> > -TEST_F(ActivityLoggerTest, LocalDOMWindowAttribute)
> > -{
> > -    const char* code =
> > -        "location.href = 'data:text/html;charset=utf-8,A';"
> > -        "location.assign('data:text/html;charset=utf-8,B');"
> > -        "location.replace('data:text/html;charset=utf-8,C');"
> > -        "location.protocol = 'protocol';"
> > -        "location.pathname = 'pathname';"
> > -        "location.search = 'search';"
> > -        "location.hash = 'hash';"
> > -        "location.href = 'about:blank';";
> > -    const char* expectedActivities =
> > -        "blinkSetAttribute | LocalDOMWindow | url | about:blank |
> > data:text/html;charset=utf-8,A\n"
> > -        "blinkSetAttribute | LocalDOMWindow | url | about:blank |
> > data:text/html;charset=utf-8,B\n"
> > -        "blinkSetAttribute | LocalDOMWindow | url | about:blank |
> > data:text/html;charset=utf-8,C\n"
> > -        "blinkSetAttribute | LocalDOMWindow | url | about:blank |
> > protocol:blank\n"
> > -        "blinkSetAttribute | LocalDOMWindow | url | about:blank |
> > about:pathname\n"
> > -        "blinkSetAttribute | LocalDOMWindow | url | about:blank |
> > about:blank?search\n"
> > -        "blinkSetAttribute | LocalDOMWindow | url | about:blank |
> > about:blank#hash\n"
> > -        "blinkSetAttribute | LocalDOMWindow | url | about:blank#hash |
> > about:blank\n";
> > -    executeScriptInMainWorld(code);
> > -    ASSERT_TRUE(verifyActivities(""));
> > -    executeScriptInIsolatedWorld(code);
> > -    ASSERT_TRUE(verifyActivities(expectedActivities));
> > -}
> > -
> >  } // namespace
> 
> This was reverted in https://codereview.chromium.org/363913002
> 
> Deleting this CL.

Hmmm, I don't have permission to delete it.

Powered by Google App Engine
This is Rietveld 408576698