Gamepad: don't notify about connected pads twice

Gamepad: don't notify about connected pads twice

Currently the first time we observe user gesture we call
GamepadConsumer::OnGamepadConnected once because of the gesture and once because of the
state change of the pad. This CL fixes that by reordering the gesture check and the
state tests in GamepadProvider the state change will be ignored by GamepadService
because did_observe_user_gesture is still false for the consumer.
Also it seems like I forget to set gesture_callback_pending_ to true when appropriate
in my former CL's, fixed it.
Added unit test for connections and made some refactoring related to unittests.

BUG=344556
R=bajones@chromium.org,scottmg@chromium.org
TBR=dmichael@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281098

[bajones, 2014-07-01 20:59:26]

On 2014/07/01 20:09:16, kbalazs wrote:

content/browser/gamepad LGTM

[dmichael (off chromium), 2014-07-01 21:02:07]

pepper lgtm

[kbalazs, 2014-07-01 21:17:30]

The CQ bit was checked by b.kelemen@samsung.com

[commit-bot: I haz the power, 2014-07-01 21:18:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/362123002/20001

[kbalazs, 2014-07-01 21:31:28]

The CQ bit was unchecked by b.kelemen@samsung.com

[kbalazs, 2014-07-01 21:32:53]

The CQ bit was checked by b.kelemen@samsung.com

[commit-bot: I haz the power, 2014-07-01 21:34:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/362123002/20001

[commit-bot: I haz the power, 2014-07-01 22:51:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[kbalazs, 2014-07-01 22:55:55]

The CQ bit was checked by b.kelemen@samsung.com

[commit-bot: I haz the power, 2014-07-01 22:56:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/362123002/40001

[commit-bot: I haz the power, 2014-07-02 01:18:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-07-02 01:31:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 01:31:16]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[kbalazs, 2014-07-02 17:31:19]

The CQ bit was checked by b.kelemen@samsung.com

[commit-bot: I haz the power, 2014-07-02 17:32:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/362123002/60001

[commit-bot: I haz the power, 2014-07-02 19:55:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-02 21:58:16]

Change committed as 281098