Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 362073004: Revert of Refactoring activity logger.

Created:
6 years, 5 months ago by eseidel
Modified:
6 years, 3 months ago
Reviewers:
haraken, esprehn, pmarch
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, feature-media-reviews_chromium.org, gasubic, sof, eae+blinkwatch, fs, eric.carlson_apple.com, vcarbune.chromium, blink-reviews-dom_chromium.org, dglazkov+blink, nessy, Inactive, gavinp+prerender_chromium.org, watchdog-blink-watchlist_google.com, philipj_slow, rwlbuis, felt, mvrable, Devlin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Refactoring activity logger. (https://codereview.chromium.org/351923005/) Reason for revert: This appears to have added a flaky test which caused the Bilnk roll to get reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=280864 Original issue's description: > Enables logger to log changes to certain elements and attributes. > > BUG=388287 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177289 TBR=haraken@chromium.org,pfeldman@chromium.org,esprehn@chromium.org,pmarch@chromium.org NOTREECHECKS=true NOTRY=true BUG=388287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -269 lines) Patch
M Source/core/dom/Document.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/URLUtils.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/html/HTMLButtonElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLButtonElement.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/html/HTMLButtonElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLEmbedElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/html/HTMLFormElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLIFrameElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLIFrameElement.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLinkElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/html/HTMLLinkElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLModElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLQuoteElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLScriptElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSourceElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTrackElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ActivityLoggerTest.cpp View 17 chunks +15 lines, -140 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
eseidel
Created Revert of Refactoring activity logger.
6 years, 5 months ago (2014-07-01 19:51:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/362073004/1
6 years, 5 months ago (2014-07-01 19:51:57 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 19:52:07 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Document.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-01 19:52:08 UTC) #4
haraken
6 years, 5 months ago (2014-07-01 23:22:20 UTC) #5
LGTM, thanks for the revert.

Powered by Google App Engine
This is Rietveld 408576698