Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 362073004: Revert of Refactoring activity logger. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLInputElement.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 addHTMLLengthToStyle(style, CSSPropertyWidth, value); 609 addHTMLLengthToStyle(style, CSSPropertyWidth, value);
610 } else if (name == heightAttr) { 610 } else if (name == heightAttr) {
611 if (m_inputType->shouldRespectHeightAndWidthAttributes()) 611 if (m_inputType->shouldRespectHeightAndWidthAttributes())
612 addHTMLLengthToStyle(style, CSSPropertyHeight, value); 612 addHTMLLengthToStyle(style, CSSPropertyHeight, value);
613 } else if (name == borderAttr && isImageButton()) 613 } else if (name == borderAttr && isImageButton())
614 applyBorderAttributeToStyle(value, style); 614 applyBorderAttributeToStyle(value, style);
615 else 615 else
616 HTMLTextFormControlElement::collectStyleForPresentationAttribute(name, v alue, style); 616 HTMLTextFormControlElement::collectStyleForPresentationAttribute(name, v alue, style);
617 } 617 }
618 618
619 void HTMLInputElement::attributeWillChange(const QualifiedName& name, const Atom icString& oldValue, const AtomicString& newValue)
620 {
621 if (name == formactionAttr && inDocument()) {
622 V8DOMActivityLogger* activityLogger = V8DOMActivityLogger::currentActivi tyLoggerIfIsolatedWorld();
623 if (activityLogger) {
624 Vector<String> argv;
625 argv.append("input");
626 argv.append(formactionAttr.toString());
627 argv.append(oldValue);
628 argv.append(newValue);
629 activityLogger->logEvent("blinkSetAttribute", argv.size(), argv.data ());
630 }
631 }
632 HTMLTextFormControlElement::attributeWillChange(name, oldValue, newValue);
633 }
634
635 void HTMLInputElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value) 619 void HTMLInputElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value)
636 { 620 {
637 if (name == nameAttr) { 621 if (name == nameAttr) {
638 removeFromRadioButtonGroup(); 622 removeFromRadioButtonGroup();
639 m_name = value; 623 m_name = value;
640 addToRadioButtonGroup(); 624 addToRadioButtonGroup();
641 HTMLTextFormControlElement::parseAttribute(name, value); 625 HTMLTextFormControlElement::parseAttribute(name, value);
642 } else if (name == autocompleteAttr) { 626 } else if (name == autocompleteAttr) {
643 if (equalIgnoringCase(value, "off")) 627 if (equalIgnoringCase(value, "off"))
644 m_autocomplete = Off; 628 m_autocomplete = Off;
(...skipping 1239 matching lines...) Expand 10 before | Expand all | Expand 10 after
1884 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer()); 1868 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());
1885 } 1869 }
1886 #endif 1870 #endif
1887 1871
1888 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue) 1872 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue)
1889 { 1873 {
1890 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ; 1874 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ;
1891 } 1875 }
1892 1876
1893 } // namespace 1877 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLInputElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698