Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: Source/core/html/HTMLButtonElement.cpp

Issue 362073004: Revert of Refactoring activity logger. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLButtonElement.h ('k') | Source/core/html/HTMLButtonElement.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 argv.append("button"); 223 argv.append("button");
224 argv.append(fastGetAttribute(typeAttr)); 224 argv.append(fastGetAttribute(typeAttr));
225 argv.append(fastGetAttribute(formmethodAttr)); 225 argv.append(fastGetAttribute(formmethodAttr));
226 argv.append(fastGetAttribute(formactionAttr)); 226 argv.append(fastGetAttribute(formactionAttr));
227 activityLogger->logEvent("blinkAddElement", argv.size(), argv.data() ); 227 activityLogger->logEvent("blinkAddElement", argv.size(), argv.data() );
228 } 228 }
229 } 229 }
230 return HTMLFormControlElement::insertedInto(insertionPoint); 230 return HTMLFormControlElement::insertedInto(insertionPoint);
231 } 231 }
232 232
233 void HTMLButtonElement::attributeWillChange(const QualifiedName& name, const Ato micString& oldValue, const AtomicString& newValue)
234 {
235 if (name == formactionAttr && inDocument()) {
236 V8DOMActivityLogger* activityLogger = V8DOMActivityLogger::currentActivi tyLoggerIfIsolatedWorld();
237 if (activityLogger) {
238 Vector<String> argv;
239 argv.append("button");
240 argv.append(formactionAttr.toString());
241 argv.append(oldValue);
242 argv.append(newValue);
243 activityLogger->logEvent("blinkSetAttribute", argv.size(), argv.data ());
244 }
245 }
246 HTMLFormControlElement::attributeWillChange(name, oldValue, newValue);
247 }
248
249 } // namespace 233 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLButtonElement.h ('k') | Source/core/html/HTMLButtonElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698