Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 361173002: [wip] simplify -webkit-appearance adjust step (Closed)

Created:
6 years, 5 months ago by Timothy Loh
Modified:
5 years, 10 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[wip] simplify -webkit-appearance adjust step work in progress; depends on https://codereview.chromium.org/350333003 - simply store a bool on whether backgrounds/borders have changed instead of storing the values - if you explicitly set the same thing as the ua style, we'll consider it styled (need to rebaseline select-style.html) - I think this fixes another visited link accessor hole :\ BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -120 lines) Patch
M Source/core/core.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/CascadedValues.h View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/css/resolver/CascadedValues.cpp View 1 2 3 3 chunks +36 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 3 2 chunks +4 lines, -7 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.h View 1 2 3 3 chunks +3 lines, -16 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderTheme.h View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 2 3 4 chunks +5 lines, -22 lines 0 comments Download
D Source/core/rendering/style/CachedUAStyle.h View 1 2 3 1 chunk +0 lines, -60 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698