Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: Source/core/css/resolver/StyleResolverState.h

Issue 361173002: [wip] simplify -webkit-appearance adjust step (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: update Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/resolver/StyleResolver.cpp ('k') | Source/core/css/resolver/StyleResolverState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/StyleResolverState.h
diff --git a/Source/core/css/resolver/StyleResolverState.h b/Source/core/css/resolver/StyleResolverState.h
index 9918765ff51d8ac095341f0bf774049922119b54..01b758d91f487afa89c95628b0885efda663c46e 100644
--- a/Source/core/css/resolver/StyleResolverState.h
+++ b/Source/core/css/resolver/StyleResolverState.h
@@ -32,7 +32,6 @@
#include "core/css/resolver/FontBuilder.h"
#include "core/dom/Document.h"
#include "core/dom/Element.h"
-#include "core/rendering/style/CachedUAStyle.h"
#include "core/rendering/style/RenderStyle.h"
#include "core/rendering/style/StyleInheritedData.h"
@@ -89,20 +88,8 @@ public:
// Holds all attribute names found while applying "content" properties that contain an "attr()" value.
Vector<AtomicString>& contentAttrValues() { return m_contentAttrValues; }
- void cacheUserAgentBorderAndBackground()
- {
- // RenderTheme only needs the cached style if it has an appearance,
- // and constructing it is expensive so we avoid it if possible.
- if (!style()->hasAppearance())
- return;
-
- m_cachedUAStyle = CachedUAStyle::create(style());
- }
-
- const CachedUAStyle* cachedUAStyle() const
- {
- return m_cachedUAStyle.get();
- }
+ void setValuesUnchangedForWebkitAppearance() { m_valuesUnchangedForWebkitAppearance = true; }
+ bool valuesUnchangedForWebkitAppearance() { return m_valuesUnchangedForWebkitAppearance; }
ElementStyleResources& elementStyleResources() { return m_elementStyleResources; }
const CSSToStyleMap& styleMap() const { return m_styleMap; }
@@ -148,7 +135,7 @@ private:
FontBuilder m_fontBuilder;
- OwnPtr<CachedUAStyle> m_cachedUAStyle;
+ bool m_valuesUnchangedForWebkitAppearance;
ElementStyleResources m_elementStyleResources;
// CSSToStyleMap is a pure-logic class and only contains
« no previous file with comments | « Source/core/css/resolver/StyleResolver.cpp ('k') | Source/core/css/resolver/StyleResolverState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698