Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 359903002: Call WTFString::split(UChar, Vector&) when possible (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
sof, abarth-chromium
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, Rik, caseq+blink_chromium.org, danakj, devtools-reviews_chromium.org, krit, eustas+blink_chromium.org, jamesr, jbroman, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Call WTFString::split(UChar, Vector&) when possible Use WTFString::split(UChar, Vector&) when possible instead of Use WTFString::split(const String&, Vector&) to avoid constructing String objects unnecessarily. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177312

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary argument #

Patch Set 3 : Update tests as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/core/editing/CompositionUnderlineRangeFilterTest.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/Navigator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/Performance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/ContentType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/gpu/Extensions3DUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ActivityLoggerTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Inactive
6 years, 5 months ago (2014-06-29 18:00:34 UTC) #1
sof
https://codereview.chromium.org/359903002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (right): https://codereview.chromium.org/359903002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp#newcode2032 Source/core/inspector/InspectorDOMAgent.cpp:2032: path.split(',', false, pathTokens); Could be shortened to path.split(',', pathTokens);
6 years, 5 months ago (2014-06-29 19:32:28 UTC) #2
Inactive
https://codereview.chromium.org/359903002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (right): https://codereview.chromium.org/359903002/diff/1/Source/core/inspector/InspectorDOMAgent.cpp#newcode2032 Source/core/inspector/InspectorDOMAgent.cpp:2032: path.split(',', false, pathTokens); On 2014/06/29 19:32:28, sof wrote: > ...
6 years, 5 months ago (2014-06-29 19:35:49 UTC) #3
sof
core/ lgtm. (There are some *Test.cpp uses that haven't been converted here, I notice.)
6 years, 5 months ago (2014-06-29 20:00:04 UTC) #4
Inactive
On 2014/06/29 20:00:04, sof wrote: > core/ lgtm. > > (There are some *Test.cpp uses ...
6 years, 5 months ago (2014-06-29 20:05:29 UTC) #5
Inactive
abarth, could you please take a look at platform/ and web/?
6 years, 5 months ago (2014-07-01 12:13:36 UTC) #6
abarth-chromium
LGTM
6 years, 5 months ago (2014-07-01 14:47:23 UTC) #7
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-07-01 14:47:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/359903002/40001
6 years, 5 months ago (2014-07-01 14:48:06 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 14:51:08 UTC) #10
Message was sent while issue was closed. 
Change committed as 177312

Powered by Google App Engine
This is Rietveld 408576698