Source/core/inspector/InspectorTimelineAgent.cpp - Issue 359903002: Call WTFString::split(UChar, Vector&) when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorTimelineAgent.cpp

Issue 359903002: Call WTFString::split(UChar, Vector&) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update tests as well Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorTimelineAgent.cpp

diff --git a/Source/core/inspector/InspectorTimelineAgent.cpp b/Source/core/inspector/InspectorTimelineAgent.cpp

index 6c4330824a3b73133acc9cd8684976ba5035a763..86e60212682e654065bbb255b61c6a363c57a2c2 100644

--- a/Source/core/inspector/InspectorTimelineAgent.cpp

+++ b/Source/core/inspector/InspectorTimelineAgent.cpp

@@ -1268,7 +1268,7 @@ void InspectorTimelineAgent::setLiveEvents(const String& liveEvents)

if (liveEvents.isNull() || liveEvents.isEmpty())

return;

Vector<String> eventList;

- liveEvents.split(",", eventList);

+ liveEvents.split(',', eventList);

for (Vector<String>::iterator it = eventList.begin(); it != eventList.end(); ++it)

m_liveEvents.add(*it);

}

« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/timing/Performance.cpp » ('j') | no next file with comments »