Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: Source/core/editing/CompositionUnderlineRangeFilterTest.cpp

Issue 359903002: Call WTFString::split(UChar, Vector&) when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update tests as well Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/Navigator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/CompositionUnderlineRangeFilterTest.cpp
diff --git a/Source/core/editing/CompositionUnderlineRangeFilterTest.cpp b/Source/core/editing/CompositionUnderlineRangeFilterTest.cpp
index ce9908bb13da6d1d63d11161350932e8c7bafab7..b8d53d1cc091633029bbfe1c70ca1b0d2641b381 100644
--- a/Source/core/editing/CompositionUnderlineRangeFilterTest.cpp
+++ b/Source/core/editing/CompositionUnderlineRangeFilterTest.cpp
@@ -21,13 +21,13 @@ void initUnderlines(const String& testCase, Vector<CompositionUnderline>* underl
{
ASSERT(underlines && underlines->size() == 0U);
Vector<String> rangeList;
- testCase.split("|", rangeList);
+ testCase.split('|', rangeList);
// Intervals are named 'A', 'B', ..., 'Z', so ensure there aren't too many.
ASSERT_LE(rangeList.size(), static_cast<size_t>('Z' - 'A'));
for (unsigned i = 0; i < rangeList.size(); ++i) {
String range = rangeList[i];
Vector<String> toks;
- rangeList[i].split(",", toks);
+ rangeList[i].split(',', toks);
ASSERT_EQ(2U, toks.size());
int startOffset = toks[0].toInt();
int endOffset = toks[1].toInt();
« no previous file with comments | « no previous file | Source/core/frame/Navigator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698