[Android] Enable composited selection updates

content/renderer/render_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 1800 matching lines @@
   *focus = focus_webrect;
   *anchor = anchor_webrect;
 }
 
 void RenderWidget::UpdateSelectionBounds() {
   if (!webwidget_)
     return;
   if (handling_ime_event_)
     return;
 
+  // With composited selection updates, the selection bounds will be reported
+  // directly by the compositor, in which case explicit IPC selection
+  // notifications should be suppressed.
+  // TODO(jdduke): Remove this when all platforms use composited updates for
+  // selection bounds, crbug.com/399721.
+#if !defined(OS_ANDROID)

[jochen (gone - plz use gerrit), 2014/09/19 13:25:11]

why not add WebRuntimeFeatures::isCompositedSelectionUpdatesEnabled() and skip
this code if it returns true?

[jdduke (slow), 2014/09/19 15:46:07]

What, and make the code both less brittle and easier to follow!?! ;) Done.

   ViewHostMsg_SelectionBounds_Params params;
   GetSelectionBounds(&params.anchor_rect, &params.focus_rect);
   if (selection_anchor_rect_ != params.anchor_rect ||
       selection_focus_rect_ != params.focus_rect) {
     selection_anchor_rect_ = params.anchor_rect;
     selection_focus_rect_ = params.focus_rect;
     webwidget_->selectionTextDirection(params.focus_dir, params.anchor_dir);
     params.is_anchor_first = webwidget_->isSelectionAnchorFirst();
     Send(new ViewHostMsg_SelectionBoundsChanged(routing_id_, params));
   }
+#endif
+
 #if defined(OS_MACOSX) || defined(USE_AURA)
   UpdateCompositionInfo(false);
 #endif
 }
 
 // Check blink::WebTextInputType and ui::TextInputType is kept in sync.
 COMPILE_ASSERT(int(blink::WebTextInputTypeNone) == \
                int(ui::TEXT_INPUT_TYPE_NONE), mismatching_enums);
 COMPILE_ASSERT(int(blink::WebTextInputTypeText) == \
                int(ui::TEXT_INPUT_TYPE_TEXT), mismatching_enums);
@@ skipping 340 matching lines @@
 void RenderWidget::RegisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.AddObserver(frame);
 }
 
 void RenderWidget::UnregisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.RemoveObserver(frame);
 }
 #endif  // defined(VIDEO_HOLE)
 
 }  // namespace content