tools/android/adb_profile_chrome/chrome_controller.py - Issue 358993003: [Android] Switch to DeviceUtils versions of file functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/adb_profile_chrome/chrome_controller.py

Issue 358993003: [Android] Switch to DeviceUtils versions of file functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/utils/reraiser_thread.py ('K') | « build/android/tombstones.py ('k') | tools/android/adb_profile_chrome/perf_controller.py » ('j') | tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/android/adb_profile_chrome/chrome_controller.py

diff --git a/tools/android/adb_profile_chrome/chrome_controller.py b/tools/android/adb_profile_chrome/chrome_controller.py

index 3dc88556eabf69eb855b928738b90ad0d43eb943..2bd5bc75b6386651287d43878341a5761b89150c 100644

--- a/tools/android/adb_profile_chrome/chrome_controller.py

+++ b/tools/android/adb_profile_chrome/chrome_controller.py

@@ -100,5 +100,5 @@ class ChromeTracingController(controllers.BaseController):

trace_file = self._trace_file.replace('/storage/emulated/0/', '/sdcard/')

host_file = os.path.join(os.path.curdir, os.path.basename(trace_file))

- self._device.old_interface.PullFileFromDevice(trace_file, host_file)

+ self._device.PullFile(trace_file, host_file)

return host_file