tools/android/adb_profile_chrome/chrome_controller.py - Issue 358993003: [Android] Switch to DeviceUtils versions of file functions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/android/adb_profile_chrome/chrome_controller.py

Issue 358993003: [Android] Switch to DeviceUtils versions of file functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« build/android/pylib/utils/reraiser_thread.py ('K') | « build/android/tombstones.py ('k') | tools/android/adb_profile_chrome/perf_controller.py » ('j') | tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import json	5 import json

6 import os	6 import os

7 import re	7 import re

8 import time	8 import time

9	9

10 from adb_profile_chrome import controllers	10 from adb_profile_chrome import controllers

(...skipping 82 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
93 if self._trace_memory:	93 if self._trace_memory:

94 self._device.old_interface.system_properties \	94 self._device.old_interface.system_properties \

95 [_HEAP_PROFILE_MMAP_PROPERTY] = 0	95 [_HEAP_PROFILE_MMAP_PROPERTY] = 0

96	96

97 def PullTrace(self):	97 def PullTrace(self):

98 # Wait a bit for the browser to finish writing the trace file.	98 # Wait a bit for the browser to finish writing the trace file.

99 time.sleep(self._trace_interval / 4 + 1)	99 time.sleep(self._trace_interval / 4 + 1)

100	100

101 trace_file = self._trace_file.replace('/storage/emulated/0/', '/sdcard/')	101 trace_file = self._trace_file.replace('/storage/emulated/0/', '/sdcard/')

102 host_file = os.path.join(os.path.curdir, os.path.basename(trace_file))	102 host_file = os.path.join(os.path.curdir, os.path.basename(trace_file))

103 self._device.old_interface.PullFileFromDevice(trace_file, host_file)	103 self._device.PullFile(trace_file, host_file)

104 return host_file	104 return host_file

OLD	NEW