build/android/pylib/utils/reraiser_thread.py - Issue 358993003: [Android] Switch to DeviceUtils versions of file functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/utils/reraiser_thread.py

Issue 358993003: [Android] Switch to DeviceUtils versions of file functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/device/device_utils.py ('K') | « build/android/pylib/uiautomator/test_package.py ('k') | build/android/pylib/valgrind_tools.py » ('j') | tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/utils/reraiser_thread.py

diff --git a/build/android/pylib/utils/reraiser_thread.py b/build/android/pylib/utils/reraiser_thread.py

index 64196b26e879448884b9ca96d07adfac4a8d8e18..2964bef1e8265e3931e2cdda15f626d8f131cc77 100644

--- a/build/android/pylib/utils/reraiser_thread.py

+++ b/build/android/pylib/utils/reraiser_thread.py

@@ -74,9 +74,8 @@ class ReraiserThread(threading.Thread):

"""Overrides Thread.run() to add support for reraising exceptions."""

try:

self._ret = self._func(*self._args, **self._kwargs)

- except:

+ except: # pylint: disable=W0702

self._exc_info = sys.exc_info()

- raise

jbudorick 2014/06/27 20:06:09 Note that this no longer will now eat exceptions i

class ReraiserThreadGroup(object):