Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 358973004: Add a preliminary R11 EAC compressor (Closed)

Created:
6 years, 5 months ago by krajcevski
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org, mtklein, bungeman-skia, tfarina
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Add some comments #

Patch Set 3 : Make everything uint16_t #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -48 lines) Patch
M src/utils/SkTextureCompressor.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/utils/SkTextureCompressor.cpp View 1 2 14 chunks +258 lines, -46 lines 1 comment Download

Messages

Total messages: 12 (0 generated)
krajcevski
6 years, 5 months ago (2014-06-27 22:24:50 UTC) #1
robertphillips
lgtm + some suggestions Do we have a unit test for this? https://codereview.chromium.org/358973004/diff/1/src/utils/SkTextureCompressor.cpp File src/utils/SkTextureCompressor.cpp ...
6 years, 5 months ago (2014-06-30 14:30:34 UTC) #2
krajcevski
https://codereview.chromium.org/358973004/diff/1/src/utils/SkTextureCompressor.cpp File src/utils/SkTextureCompressor.cpp (right): https://codereview.chromium.org/358973004/diff/1/src/utils/SkTextureCompressor.cpp#newcode31 src/utils/SkTextureCompressor.cpp:31: On 2014/06/30 14:30:34, robertphillips wrote: > // This method ...
6 years, 5 months ago (2014-06-30 14:53:13 UTC) #3
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 5 months ago (2014-06-30 14:53:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/358973004/20001
6 years, 5 months ago (2014-06-30 14:54:22 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win7-VS2010-x86-Debug-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-06-30 15:08:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 15:14:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win7-VS2010-x86-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Debug-Trybot/builds/590)
6 years, 5 months ago (2014-06-30 15:14:33 UTC) #8
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 5 months ago (2014-06-30 15:15:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/358973004/40001
6 years, 5 months ago (2014-06-30 15:15:22 UTC) #10
commit-bot: I haz the power
Change committed as f3d15dc13abb825946ccad514412699828d5d709
6 years, 5 months ago (2014-06-30 15:47:38 UTC) #11
tfarina
6 years, 5 months ago (2014-07-12 02:07:28 UTC) #12
Message was sent while issue was closed. 
https://codereview.chromium.org/358973004/diff/40001/src/utils/SkTextureCompr...
File src/utils/SkTextureCompressor.cpp (right):

https://codereview.chromium.org/358973004/diff/40001/src/utils/SkTextureCompr...
src/utils/SkTextureCompressor.cpp:389: const int *palette =
kR11EACModifierPalettes[paletteIdx];
clang is warning on me:

../../src/utils/SkTextureCompressor.cpp:315:18: error: unused variable
'kR11EACModifierPalettes' [-Werror,-Wunused-const-variable]
static const int kR11EACModifierPalettes[kNumR11EACPalettes][kR11EACPaletteSize]
= {


Did you compile with gcc or clang?

Powered by Google App Engine
This is Rietveld 408576698