Issue 358913003: Get rid of one-off code in ScrollingCoordinator to handle graphics layer offsets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 358913003: Get rid of one-off code in ScrollingCoordinator to handle graphics layer offsets. (Closed)

Created:
6 years, 6 months ago by chrishtr

Modified:
6 years, 5 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, kenneth.christiansen, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Get rid of one-off code in ScrollingCoordinator to handle graphics layer offsets. This allows us to remove a redundant squashing-related property in RenderLayer, and is also a step towards not having non-compositing code know about how the layers are positioned & drawn. BUG=384520 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177133

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -35 lines)			Patch
M	Source/core/page/scrolling/ScrollingCoordinator.cpp	View	1 2	4 chunks	+3 lines, -12 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.h	View	1 2	3 chunks	+2 lines, -6 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	1 2 3 4	2 chunks	+21 lines, -9 lines	0 comments	Download
M	Source/core/rendering/compositing/CompositedLayerMapping.cpp	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/testing/Internals.cpp	View	1 2	2 chunks	+6 lines, -4 lines	0 comments	Download