Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 357903003: Revert 279958 "Revert "Revert 279650 "Add VaapiVideoEncodeAccele..." (Closed)

Created:
6 years, 5 months ago by James Cook
Modified:
6 years, 5 months ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 279958 "Revert "Revert 279650 "Add VaapiVideoEncodeAccele..." This once again broke the cros_x86 builder. I think you want the Range to be static_cast<size_t> not static_cast<uint64>. http://build.chromium.org/p/chromiumos.chromium/builders/X86%20%28chromium%29/builds/333 chromeos-chrome-38.0.2071.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/media/filters/h264_bitstream_buffer_unittest.cc:52:226: error: could not convert 'testing::Range(T, T) [with T = long long unsigned int](65ull)' from 'testing::internal::ParamGenerator<long long unsigned int>' to 'testing::internal::ParamGenerator<unsigned int>' chromeos-chrome-38.0.2071.0_alpha-r1: INSTANTIATE_TEST_CASE_P(AppendNumBits, > Revert "Revert 279650 "Add VaapiVideoEncodeAccelerator for HW-accelerate..."" > > Fixing the cros_trunk builder compilation failure in > h264_bitstream_buffer_unittest, for which this was reverted. > > > Revert 279650 "Add VaapiVideoEncodeAccelerator for HW-accelerate..." > > > > Broke the Chrome-on-Chrome OS compile > > > > http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/21417 > > > > > Add VaapiVideoEncodeAccelerator for HW-accelerated video encode. > > > > > > Add an implementation of VideoEncodeAccelerator utilizing VA-API for > > > hardware encode on Intel-based ChromeOS platforms. > > > > > > BUG=378962 > > > TEST=video_encode_accelerator_unittest > > > > > > Review URL: https://codereview.chromium.org/333253002 > > > > TBR=posciak@chromium.org > > > > Review URL: https://codereview.chromium.org/350413002 > > > > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279733 0039d316-1c4b-4281-b951-d872f2087c98 > > TBR=jamescook@chromium.org > BUG=388778, 378962 > > Review URL: https://codereview.chromium.org/356903002 TBR=posciak@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -2186 lines) Patch
M trunk/src/chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/common/gpu/media/gpu_video_encode_accelerator.cc View 3 chunks +3 lines, -22 lines 0 comments Download
M trunk/src/content/common/gpu/media/h264_dpb.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/common/gpu/media/va.sigs View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/common/gpu/media/vaapi_h264_decoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/common/gpu/media/vaapi_h264_decoder_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/common/gpu/media/vaapi_video_decode_accelerator.cc View 1 chunk +1 line, -3 lines 0 comments Download
D trunk/src/content/common/gpu/media/vaapi_video_encode_accelerator.h View 1 chunk +0 lines, -264 lines 0 comments Download
D trunk/src/content/common/gpu/media/vaapi_video_encode_accelerator.cc View 1 chunk +0 lines, -1061 lines 0 comments Download
M trunk/src/content/common/gpu/media/vaapi_wrapper.h View 6 chunks +21 lines, -67 lines 0 comments Download
M trunk/src/content/common/gpu/media/vaapi_wrapper.cc View 10 chunks +31 lines, -282 lines 0 comments Download
M trunk/src/content/common/gpu/media/video_encode_accelerator_unittest.cc View 7 chunks +18 lines, -48 lines 0 comments Download
M trunk/src/content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M trunk/src/content/content_common.gypi View 3 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 2 chunks +1 line, -12 lines 0 comments Download
M trunk/src/content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D trunk/src/media/filters/h264_bitstream_buffer.h View 1 chunk +0 lines, -120 lines 0 comments Download
D trunk/src/media/filters/h264_bitstream_buffer.cc View 1 chunk +0 lines, -152 lines 0 comments Download
D trunk/src/media/filters/h264_bitstream_buffer_unittest.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M trunk/src/media/filters/h264_parser.h View 2 chunks +0 lines, -39 lines 0 comments Download
M trunk/src/media/filters/h264_parser.cc View 2 chunks +5 lines, -1 line 0 comments Download
M trunk/src/media/media.gyp View 2 chunks +0 lines, -12 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Cook
6 years, 5 months ago (2014-06-26 16:23:42 UTC) #1
James Cook
6 years, 5 months ago (2014-06-26 16:24:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r280020.

Powered by Google App Engine
This is Rietveld 408576698