Chromium Code Reviews
Help | Chromium Project | Sign in
(76)

Issue 356903002: Revert "Revert 279650 "Add VaapiVideoEncodeAccelerator for HW-accelerate..."" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months ago by Pawel Osciak
Modified:
9 months ago
Reviewers:
James Cook
CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, wjia+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, asvitkine+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, jln+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert "Revert 279650 "Add VaapiVideoEncodeAccelerator for HW-accelerate..."" Fixing the cros_trunk builder compilation failure in h264_bitstream_buffer_unittest, for which this was reverted. > Revert 279650 "Add VaapiVideoEncodeAccelerator for HW-accelerate..." > > Broke the Chrome-on-Chrome OS compile > > http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/21417 > > > Add VaapiVideoEncodeAccelerator for HW-accelerated video encode. > > > > Add an implementation of VideoEncodeAccelerator utilizing VA-API for > > hardware encode on Intel-based ChromeOS platforms. > > > > BUG=378962 > > TEST=video_encode_accelerator_unittest > > > > Review URL: https://codereview.chromium.org/333253002 > > TBR=posciak@chromium.org > > Review URL: https://codereview.chromium.org/350413002 > > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279733 0039d316-1c4b-4281-b951-d872f2087c98 TBR=jamescook@chromium.org BUG=388778, 378962 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2186 lines, -87 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 3 chunks +22 lines, -3 lines 0 comments Download
M content/common/gpu/media/h264_dpb.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/media/va.sigs View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 1 chunk +3 lines, -1 line 0 comments Download
A content/common/gpu/media/vaapi_video_encode_accelerator.h View 1 chunk +264 lines, -0 lines 0 comments Download
A content/common/gpu/media/vaapi_video_encode_accelerator.cc View 1 chunk +1061 lines, -0 lines 0 comments Download
M content/common/gpu/media/vaapi_wrapper.h View 6 chunks +67 lines, -21 lines 0 comments Download
M content/common/gpu/media/vaapi_wrapper.cc View 10 chunks +282 lines, -31 lines 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 7 chunks +48 lines, -18 lines 0 comments Download
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M content/content_common.gypi View 3 chunks +7 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +12 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A media/filters/h264_bitstream_buffer.h View 1 chunk +120 lines, -0 lines 0 comments Download
A media/filters/h264_bitstream_buffer.cc View 1 chunk +152 lines, -0 lines 0 comments Download
A media/filters/h264_bitstream_buffer_unittest.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M media/filters/h264_parser.h View 2 chunks +39 lines, -0 lines 0 comments Download
M media/filters/h264_parser.cc View 2 chunks +1 line, -5 lines 0 comments Download
M media/media.gyp View 2 chunks +12 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +11 lines, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
9 months ago (2014-06-26 05:04:26 UTC) #1
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/356903002/1
9 months ago (2014-06-26 05:06:42 UTC) #2
I haz the power (commit-bot)
Change committed as 279958
9 months ago (2014-06-26 08:13:29 UTC) #3
James Cook
9 months ago (2014-06-26 16:25:06 UTC) #4
Message was sent while issue was closed.
On 2014/06/26 08:13:29, I haz the power (commit-bot) wrote:
> Change committed as 279958

Reverted with https://codereview.chromium.org/357903003 at crrev.com/280020.

This once again broke the cros_x86 builder. I think you want the Range to be
static_cast<size_t> not static_cast<uint64>.

http://build.chromium.org/p/chromiumos.chromium/builders/X86%20%28chromium%29...

chromeos-chrome-38.0.2071.0_alpha-r1:
../../../../../../../home/chrome-bot/chrome_root/src/media/filters/h264_bitstream_buffer_unittest.cc:
In function 'testing::internal::ParamGenerator<unsigned int>
media::gtest_AppendNumBitsH264BitstreamBufferAppendBitsTest_EvalGenerator_()':
chromeos-chrome-38.0.2071.0_alpha-r1:
../../../../../../../home/chrome-bot/chrome_root/src/media/filters/h264_bitstream_buffer_unittest.cc:52:226:
error: could not convert 'testing::Range(T, T) [with T = long long unsigned
int](65ull)' from 'testing::internal::ParamGenerator<long long unsigned int>' to
'testing::internal::ParamGenerator<unsigned int>'
chromeos-chrome-38.0.2071.0_alpha-r1:  INSTANTIATE_TEST_CASE_P(AppendNumBits,
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted